Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2960573002:
Disable FullStackTest.SimulcastFullHdOveruse on Mac (Closed)
|
Created:
3 years, 6 months ago by kjellander_webrtc Modified:
3 years, 6 months ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDisable FullStackTest.SimulcastFullHdOveruse on Mac
This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes
webrtc_perf_tests fail+timeout on Mac:
https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896
[ RUN ] FullStackTest.SimulcastFullHdOveruse
- Uh, I'm-I'm not quite dead, sir.
- Uh, I-I think uh, I could pull through, sir.
../../webrtc/video/video_quality_test.cc:419: Failure
Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591
Analyzer stalled while waiting for test to finish.
TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org
BUG=webrtc:7375, webrtc:6958
NOTRY=True
Review-Url: https://codereview.webrtc.org/2960573002
Cr-Commit-Position: refs/heads/master@{#18748}
Committed: https://chromium.googlesource.com/external/webrtc/+/7790e8779d8965107d625e1fc894e21fece150dd
Patch Set 1 #Patch Set 2 : Rebased manually #Patch Set 3 : Just disable the test instead #Messages
Total messages: 16 (9 generated)
The CQ bit was checked by kjellander@webrtc.org
Created Revert of Add cropping to VIEEncoder to match simulcast streams resolution
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/21224) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/26752) presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18531)
Description was changed from ========== Revert of Add cropping to VIEEncoder to match simulcast streams resolution (patchset #4 id:60001 of https://codereview.webrtc.org/2936393002/ ) Reason for revert: Makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. Original issue's description: > Add cropping to VIEEncoder to match simulcast streams resolution > > Detect when simulcaststreamfactory adjust resolution and remeber cropping > parameters in VIEEncoder. > Expose EncoderStreamFactory in webrtcvideoengine2. > > BUG=webrtc:7375, webrtc:6958 > > Review-Url: https://codereview.webrtc.org/2936393002 > Cr-Commit-Position: refs/heads/master@{#18632} > Committed: https://chromium.googlesource.com/external/webrtc/+/6b826ef66dbdfd1688d0b64b7... TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7375, webrtc:6958 ========== to ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 ==========
Description was changed from ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 ========== to ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 ==========
Patchset #3 (id:230001) has been deleted
Description was changed from ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 ========== to ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 NOTRY=True ==========
It seemed to risky to revert so I filed a bug and just disabled the problematic test instead on Mac. Hopefully it's enough to make the perf bot stable again.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 30002, "attempt_start_ts": 1498423686061520,
"parent_rev": "1eef33e8c8375525c56678fd8fc88b03ac75804b", "commit_rev":
"7790e8779d8965107d625e1fc894e21fece150dd"}
Message was sent while issue was closed.
Description was changed from ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 NOTRY=True ========== to ========== Disable FullStackTest.SimulcastFullHdOveruse on Mac This test was added in "Add cropping to VIEEncoder to match simulcast streams resolution (https://codereview.webrtc.org/2936393002) and makes webrtc_perf_tests fail+timeout on Mac: https://build.chromium.org/p/client.webrtc.perf/builders/Mac%2010.11/builds/2896 [ RUN ] FullStackTest.SimulcastFullHdOveruse - Uh, I'm-I'm not quite dead, sir. - Uh, I-I think uh, I could pull through, sir. ../../webrtc/video/video_quality_test.cc:419: Failure Expected: (frames_processed) > (last_frames_processed), actual: 591 vs 591 Analyzer stalled while waiting for test to finish. TBR=sprang@webrtc.org,magjed@webrtc.org,ilnik@webrtc.org BUG=webrtc:7375, webrtc:6958 NOTRY=True Review-Url: https://codereview.webrtc.org/2960573002 Cr-Commit-Position: refs/heads/master@{#18748} Committed: https://chromium.googlesource.com/external/webrtc/+/7790e8779d8965107d625e1fc... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:30002) as https://chromium.googlesource.com/external/webrtc/+/7790e8779d8965107d625e1fc...
Message was sent while issue was closed.
On 2017/06/25 19:54:02, kjellander_webrtc wrote: > It seemed to risky to revert so I filed a bug and just disabled the problematic > test instead on Mac. Hopefully it's enough to make the perf bot stable again. Thanks for taking care of it. I am looking into that. |
