Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 113c2e556d5e10fbb0fa4547a102d8aebd4903df..60656c61a2b4c3cbbe4c86ad48f833e045391b4a 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -41,6 +41,7 @@
#include "net/base/net_errors.h"
#include "net/server/http_server_request_info.h"
#include "net/server/http_server_response_info.h"
+#include "net/socket/server_socket.h"
#if defined(OS_ANDROID)
#include "base/android/build_info.h"
@@ -69,12 +70,15 @@ const char kTargetFaviconUrlField[] = "faviconUrl";
const char kTargetWebSocketDebuggerUrlField[] = "webSocketDebuggerUrl";
const char kTargetDevtoolsFrontendUrlField[] = "devtoolsFrontendUrl";
+// Maximum write buffer size of devtools websocket.
+const int32 kSendBufferSizeForDevToolsWebSocket = 100 * 1024 * 1024; // 100Mb
+
// An internal implementation of DevToolsClientHost that delegates
// messages sent for DevToolsClient to a DebuggerShell instance.
class DevToolsClientHostImpl : public DevToolsClientHost {
public:
DevToolsClientHostImpl(base::MessageLoop* message_loop,
- net::HttpServer* server,
+ base::WeakPtr<net::HttpServer> server,
int connection_id)
: message_loop_(message_loop),
server_(server),
@@ -123,7 +127,7 @@ class DevToolsClientHostImpl : public DevToolsClientHost {
private:
base::MessageLoop* message_loop_;
- net::HttpServer* server_;
+ base::WeakPtr<net::HttpServer> server_;
int connection_id_;
bool is_closed_;
std::string detach_reason_;
@@ -153,12 +157,12 @@ int DevToolsHttpHandler::GetFrontendResourceId(const std::string& name) {
// static
DevToolsHttpHandler* DevToolsHttpHandler::Start(
- const net::StreamListenSocketFactory* socket_factory,
+ scoped_ptr<net::ServerSocketFactory> server_socket_factory,
const std::string& frontend_url,
DevToolsHttpHandlerDelegate* delegate,
const base::FilePath& active_port_output_directory) {
DevToolsHttpHandlerImpl* http_handler =
- new DevToolsHttpHandlerImpl(socket_factory,
+ new DevToolsHttpHandlerImpl(server_socket_factory.Pass(),
frontend_url,
delegate,
active_port_output_directory);
@@ -332,7 +336,8 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequest(
server_->Send500(connection_id, "Another client already attached");
return;
}
- browser_target_ = new DevToolsBrowserTarget(server_.get(), connection_id);
+ browser_target_ = new DevToolsBrowserTarget(server_->GetWeakPtr(),
+ connection_id);
browser_target_->RegisterDomainHandler(
devtools::Tracing::kName,
new DevToolsTracingHandler(DevToolsTracingHandler::Browser),
@@ -613,7 +618,7 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
}
DevToolsClientHostImpl* client_host = new DevToolsClientHostImpl(
- thread_->message_loop(), server_.get(), connection_id);
+ thread_->message_loop(), server_->GetWeakPtr(), connection_id);
connection_to_client_host_ui_[connection_id] = client_host;
DevToolsManager::GetInstance()->
@@ -647,12 +652,12 @@ void DevToolsHttpHandlerImpl::OnCloseUI(int connection_id) {
}
DevToolsHttpHandlerImpl::DevToolsHttpHandlerImpl(
- const net::StreamListenSocketFactory* socket_factory,
+ scoped_ptr<net::ServerSocketFactory> server_socket_factory,
const std::string& frontend_url,
DevToolsHttpHandlerDelegate* delegate,
const base::FilePath& active_port_output_directory)
: frontend_url_(frontend_url),
- socket_factory_(socket_factory),
+ server_socket_factory_(server_socket_factory.Pass()),
delegate_(delegate),
active_port_output_directory_(active_port_output_directory) {
if (frontend_url_.empty())
@@ -664,14 +669,15 @@ DevToolsHttpHandlerImpl::DevToolsHttpHandlerImpl(
// Runs on the handler thread
void DevToolsHttpHandlerImpl::Init() {
- server_ = new net::HttpServer(*socket_factory_.get(), this);
+ server_.reset(new net::HttpServer(server_socket_factory_->CreateAndListen(),
+ this));
if (!active_port_output_directory_.empty())
WriteActivePortToUserProfile();
}
// Runs on the handler thread
void DevToolsHttpHandlerImpl::Teardown() {
- server_ = NULL;
+ server_.reset(NULL);
}
// Runs on FILE thread to make sure that it is serialized against
@@ -731,7 +737,7 @@ void DevToolsHttpHandlerImpl::SendJson(int connection_id,
thread_->message_loop()->PostTask(
FROM_HERE,
base::Bind(&net::HttpServer::SendResponse,
- server_.get(),
+ server_->GetWeakPtr(),
connection_id,
response));
}
@@ -744,7 +750,7 @@ void DevToolsHttpHandlerImpl::Send200(int connection_id,
thread_->message_loop()->PostTask(
FROM_HERE,
base::Bind(&net::HttpServer::Send200,
- server_.get(),
+ server_->GetWeakPtr(),
connection_id,
data,
mime_type));
@@ -755,7 +761,9 @@ void DevToolsHttpHandlerImpl::Send404(int connection_id) {
return;
thread_->message_loop()->PostTask(
FROM_HERE,
- base::Bind(&net::HttpServer::Send404, server_.get(), connection_id));
+ base::Bind(&net::HttpServer::Send404,
+ server_->GetWeakPtr(),
+ connection_id));
}
void DevToolsHttpHandlerImpl::Send500(int connection_id,
@@ -764,7 +772,9 @@ void DevToolsHttpHandlerImpl::Send500(int connection_id,
return;
thread_->message_loop()->PostTask(
FROM_HERE,
- base::Bind(&net::HttpServer::Send500, server_.get(), connection_id,
+ base::Bind(&net::HttpServer::Send500,
+ server_->GetWeakPtr(),
+ connection_id,
message));
}
@@ -775,8 +785,16 @@ void DevToolsHttpHandlerImpl::AcceptWebSocket(
return;
thread_->message_loop()->PostTask(
FROM_HERE,
- base::Bind(&net::HttpServer::AcceptWebSocket, server_.get(),
- connection_id, request));
+ base::Bind(&net::HttpServer::SetSendBufferSize,
+ server_->GetWeakPtr(),
+ connection_id,
+ kSendBufferSizeForDevToolsWebSocket));
+ thread_->message_loop()->PostTask(
+ FROM_HERE,
+ base::Bind(&net::HttpServer::AcceptWebSocket,
+ server_->GetWeakPtr(),
+ connection_id,
+ request));
}
base::DictionaryValue* DevToolsHttpHandlerImpl::SerializeTarget(

Powered by Google App Engine
This is Rietveld 408576698