Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/device/android_web_socket.cc ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | net/server/http_connection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/remote_debugging_server.cc
diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc
index 211ff1a55cd80e7ac4bddb4c9146302ef21a10b7..ef3c9f158541994c63df391b085f2d47e20ea934 100644
--- a/chrome/browser/devtools/remote_debugging_server.cc
+++ b/chrome/browser/devtools/remote_debugging_server.cc
@@ -9,7 +9,7 @@
#include "chrome/browser/ui/webui/devtools_ui.h"
#include "chrome/common/chrome_paths.h"
#include "content/public/browser/devtools_http_handler.h"
-#include "net/socket/tcp_listen_socket.h"
+#include "net/socket/tcp_server_socket.h"
RemoteDebuggingServer::RemoteDebuggingServer(
chrome::HostDesktopType host_desktop_type,
@@ -24,8 +24,11 @@ RemoteDebuggingServer::RemoteDebuggingServer(
DCHECK(result);
}
+ scoped_ptr<net::ServerSocketFactory> factory(
+ new net::TCPServerSocketFactory());
+ factory->SetAddressAndPort(ip, port);
devtools_http_handler_ = content::DevToolsHttpHandler::Start(
- new net::TCPListenSocketFactory(ip, port),
+ factory.Pass(),
"",
new BrowserListTabContentsProvider(host_desktop_type),
output_dir);
« no previous file with comments | « chrome/browser/devtools/device/android_web_socket.cc ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | net/server/http_connection.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698