extensions/browser/api/socket/tcp_socket.cc - Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/tcp_socket.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use base::StringPiece in some places not to copy data. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/socket/tcp_socket.cc

diff --git a/extensions/browser/api/socket/tcp_socket.cc b/extensions/browser/api/socket/tcp_socket.cc

index 49f17dcf418d2324b13527353ab0d2eee2f9ec4c..28383d3c9501e62b5889b25a4a8828b984c59525 100644

--- a/extensions/browser/api/socket/tcp_socket.cc

+++ b/extensions/browser/api/socket/tcp_socket.cc

@@ -196,6 +196,7 @@ int TCPSocket::Listen(const std::string& address,

DCHECK(!socket_.get());

socket_mode_ = SERVER;

+ // TODO(byungchul): Use ServerSocketFactory.

scoped_ptr<net::IPEndPoint> bind_address(new net::IPEndPoint());

if (!StringAndPortToIPEndPoint(address, port, bind_address.get()))

return net::ERR_INVALID_ARGUMENT;

« no previous file with comments | « content/public/browser/devtools_http_handler.h ('k') | mojo/spy/websocket_server.h » ('j') | net/server/http_connection.h » ('J')