chrome/browser/devtools/device/android_web_socket.cc - Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/android_web_socket.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use base::StringPiece in some places not to copy data. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/android_web_socket.cc

diff --git a/chrome/browser/devtools/device/android_web_socket.cc b/chrome/browser/devtools/device/android_web_socket.cc

index d08cd2c4ef5dd1a51b58b026ac0991280da25194..cde68011b439a39c3bcca70fb48cf4b87e4acc25 100644

--- a/chrome/browser/devtools/device/android_web_socket.cc

+++ b/chrome/browser/devtools/device/android_web_socket.cc

@@ -150,8 +150,7 @@ void WebSocketImpl::OnBytesRead(

return;

}

- std::string data = std::string(response_buffer->data(), result);

- response_buffer_ += data;

+ response_buffer_.append(response_buffer->data(), result);

int bytes_consumed;

std::string output;

« no previous file with comments | « no previous file | chrome/browser/devtools/remote_debugging_server.cc » ('j') | net/server/http_connection.h » ('J')