Replace StreamListenSocket with StreamSocket in HttpServer.

content/public/browser/devtools_http_handler.h

Index: content/public/browser/devtools_http_handler.h
diff --git a/content/public/browser/devtools_http_handler.h b/content/public/browser/devtools_http_handler.h
index cdceff8dfd4d8f531a5cb0db0cbc3479810aa817..2b656b649580c0839eed53504954e51460f67ac4 100644
--- a/content/public/browser/devtools_http_handler.h
+++ b/content/public/browser/devtools_http_handler.h
@@ -8,12 +8,13 @@
 #include <string>
 
 #include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
 
 class GURL;
 
 namespace net {
-class StreamListenSocketFactory;
+class ServerSocket;
 class URLRequestContextGetter;
 }
 
@@ -26,6 +27,32 @@ class DevToolsHttpHandlerDelegate;
 // this browser.
 class DevToolsHttpHandler {
  public:
+
+  // Factory of net::ServerSocket. This is to separate instantiating dev tools
+  // and instantiating server socket.
+  class CONTENT_EXPORT ServerSocketFactory {

[pfeldman, 2014/08/18 15:18:00]

- content API suggests that all interfaces are defined in their own classes
- this does not belong neither to the devtools nor to content, could you expose
it in next to the net::ServerSocket?

[byungchul, 2014/08/19 22:26:10]

This factory is used only by devtools to give delay between
DevToolsHttpHandler::Start() and server socket creation, actullay to run them in
different thread.
Aren't many delegate defined in its delegated class, for example,
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...
?

[mmenke, 2014/08/19 22:43:55]

This doesn't really seem to belong in net/.  It's a wrapper around net's server
socket constructors specifically intended for use by DevTools, and does not seem
generally useful.

+   public:
+    ServerSocketFactory(const std::string& address, int port, int backlog);
+    virtual ~ServerSocketFactory();
+
+    // Returns a new instance of ServerSocket or NULL if an error occurred.
+    // It calls ServerSocket::ListenWithAddressAndPort() with address, port and
+    // backlog passed to constructor.
+    virtual scoped_ptr<net::ServerSocket> CreateAndListen() const;
+
+   protected:
+    // Creates a server socket. ServerSocket::Listen() will be called soon
+    // unless it returns NULL.
+    virtual scoped_ptr<net::ServerSocket> Create() const = 0;
+
+    const std::string address_;
+    const int port_;
+    const int backlog_;
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(ServerSocketFactory);
+  };
+
   // Returns true if the given protocol version is supported.
   CONTENT_EXPORT static bool IsSupportedProtocolVersion(
       const std::string& version);
@@ -40,7 +67,7 @@ class DevToolsHttpHandler {
   // port selected by the OS will be written to a well-known file in
   // the output directory.
   CONTENT_EXPORT static DevToolsHttpHandler* Start(
-      const net::StreamListenSocketFactory* socket_factory,
+      scoped_ptr<ServerSocketFactory> server_socket_factory,
       const std::string& frontend_url,
       DevToolsHttpHandlerDelegate* delegate,
       const base::FilePath& active_port_output_directory);