Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/android/dev_tools_server.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unittest errors. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/dev_tools_server.cc
diff --git a/chrome/browser/android/dev_tools_server.cc b/chrome/browser/android/dev_tools_server.cc
index 158ef749189f9478be6b63e4a37277e2d9c323a7..b82e3a6e4a3191029872a901a6deae3365b81d52 100644
--- a/chrome/browser/android/dev_tools_server.cc
+++ b/chrome/browser/android/dev_tools_server.cc
@@ -40,7 +40,9 @@
#include "content/public/common/user_agent.h"
#include "grit/browser_resources.h"
#include "jni/DevToolsServer_jni.h"
+#include "net/base/net_errors.h"
#include "net/socket/unix_domain_listen_socket_posix.h"
+#include "net/socket/unix_domain_server_socket_posix.h"
#include "net/url_request/url_request_context_getter.h"
#include "ui/base/resource/resource_bundle.h"
@@ -393,6 +395,44 @@ class DevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate {
DISALLOW_COPY_AND_ASSIGN(DevToolsServerDelegate);
};
+// Factory for UnixDomainServerSocket. It tries a fallback socket when
+// original socket doesn't work.
+class UnixDomainServerSocketFactory
+ : public content::DevToolsHttpHandler::ServerSocketFactory {
+ public:
+ explicit UnixDomainServerSocketFactory(const std::string& socket_name)
+ : content::DevToolsHttpHandler::ServerSocketFactory(socket_name, 0, 1) {}
+
+ private:
+ // content::DevToolsHttpHandler::ServerSocketFactory.
+ virtual scoped_ptr<net::ServerSocket> Create() const OVERRIDE {
+ return scoped_ptr<net::ServerSocket>(
+ new net::UnixDomainServerSocket(
+ base::Bind(&content::CanUserConnectToDevTools),
+ true));
+ }
+
+ virtual scoped_ptr<net::ServerSocket> CreateAndListen() const OVERRIDE {
+ scoped_ptr<net::ServerSocket> socket = Create();
+ if (!socket)
+ return scoped_ptr<net::ServerSocket>();
+
+ if (socket->ListenWithAddressAndPort(address_, port_, backlog_) == net::OK)
+ return socket.Pass();
+
+ // Try a fallback socket name.
+ const std::string fallback_address(
+ base::StringPrintf("%s_%d", address_.c_str(), getpid()));
+ if (socket->ListenWithAddressAndPort(fallback_address, port_, backlog_)
+ == net::OK)
+ return socket.Pass();
+
+ return scoped_ptr<net::ServerSocket>();
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(UnixDomainServerSocketFactory);
+};
+
} // namespace
DevToolsServer::DevToolsServer(const std::string& socket_name_prefix)
@@ -415,16 +455,14 @@ void DevToolsServer::Start(bool allow_debug_permission) {
if (protocol_handler_)
return;
+ scoped_ptr<content::DevToolsHttpHandler::ServerSocketFactory> factory(
+ new UnixDomainServerSocketFactory(socket_name_));
net::UnixDomainServerSocket::AuthCallback auth_callback =
allow_debug_permission ?
base::Bind(&AuthorizeSocketAccessWithDebugPermission) :
base::Bind(&content::CanUserConnectToDevTools);
-
protocol_handler_ = content::DevToolsHttpHandler::Start(
- new net::deprecated::UnixDomainListenSocketWithAbstractNamespaceFactory(
- socket_name_,
- base::StringPrintf("%s_%d", socket_name_.c_str(), getpid()),
- auth_callback),
+ factory.Pass(),
base::StringPrintf(kFrontEndURL, content::GetWebKitRevision().c_str()),
new DevToolsServerDelegate(auth_callback),
base::FilePath());

Powered by Google App Engine
This is Rietveld 408576698