Chromium Code Reviews| Index: net/socket/server_socket.h |
| diff --git a/net/socket/server_socket.h b/net/socket/server_socket.h |
| index 11151eea1539636928b64aee65876dfacd9e60ec..8729337275d8a52e419d000d225d4f9237df2b75 100644 |
| --- a/net/socket/server_socket.h |
| +++ b/net/socket/server_socket.h |
| @@ -7,26 +7,34 @@ |
| #include "base/memory/scoped_ptr.h" |
| #include "net/base/completion_callback.h" |
| +#include "net/base/ip_endpoint.h" |
| #include "net/base/net_export.h" |
| namespace net { |
| -class IPEndPoint; |
| class StreamSocket; |
| class NET_EXPORT ServerSocket { |
| public: |
| - ServerSocket() { } |
| - virtual ~ServerSocket() { } |
| + ServerSocket(); |
| + virtual ~ServerSocket(); |
| - // Bind the socket and start listening. Destroy the socket to stop |
| + // Binds the socket and start listening. Destroy the socket to stop |
| // listening. |
| virtual int Listen(const net::IPEndPoint& address, int backlog) = 0; |
| + // Binds the socket with address and port, and start listening. It expects |
| + // a vaild IPv4 or IPv6 address. Otherwise, it returns ERR_ADDRESS_INVALID. |
| + // Subclasses may override this function if |ip_address| is not a valid IP |
| + // address. |
|
mmenke
2014/06/11 16:05:50
The last sentence is confusing - unclear what it's
byungchul
2014/06/20 08:22:32
Revised in the other CL, https://codereview.chromi
|
| + virtual int ListenWithAddressAndPort(const std::string& ip_address, |
| + int port, |
| + int backlog); |
| + |
| // Gets current address the socket is bound to. |
| virtual int GetLocalAddress(IPEndPoint* address) const = 0; |
| - // Accept connection. Callback is called when new connection is |
| + // Accepts connection. Callback is called when new connection is |
| // accepted. |
| virtual int Accept(scoped_ptr<StreamSocket>* socket, |
| const CompletionCallback& callback) = 0; |