Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: net/socket/tcp_server_socket.cc

Issue 296053012: Replace StreamListenSocket with StreamSocket in HttpServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/tcp_server_socket.h ('K') | « net/socket/tcp_server_socket.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/tcp_server_socket.cc
diff --git a/net/socket/tcp_server_socket.cc b/net/socket/tcp_server_socket.cc
index a25f73f6c6f2717d6af3c2ee6fa5cb4be2eca896..b34298c8d88cfdbc6ba75bb9ebcaa3ea9484d82e 100644
--- a/net/socket/tcp_server_socket.cc
+++ b/net/socket/tcp_server_socket.cc
@@ -102,4 +102,19 @@ void TCPServerSocket::OnAcceptCompleted(
forward_callback.Run(result);
}
+// static
+scoped_ptr<TCPServerSocket> TCPServerSocket::Create(const std::string& ip,
+ int port) {
+ IPAddressNumber ip_number;
+ if (!ParseIPLiteralToNumber(ip, &ip_number)) {
+ return scoped_ptr<TCPServerSocket>();
+ }
+ scoped_ptr<TCPServerSocket> server_socket(
+ new TCPServerSocket(NULL, net::NetLog::Source()));
+ if (server_socket->Listen(net::IPEndPoint(ip_number, 0), 3) != OK) {
mmenke 2014/05/23 19:20:58 You should be passing in the port here.
mmenke 2014/05/23 19:20:58 Having a hard-coded backlog here seems like a bad
byungchul 2014/05/30 00:19:02 Done.
+ return scoped_ptr<TCPServerSocket>();
+ }
+ return server_socket.Pass();
+}
+
} // namespace net
« net/socket/tcp_server_socket.h ('K') | « net/socket/tcp_server_socket.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698