Replace StreamListenSocket with StreamSocket in HttpServer.

chrome/test/chromedriver/net/test_http_server.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/net/test_http_server.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
 #include "net/server/http_server_request_info.h"
-#include "net/socket/tcp_listen_socket.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TestHttpServer::TestHttpServer()
     : thread_("ServerThread"),
       all_closed_event_(false, true),
       request_action_(kAccept),
       message_action_(kEchoMessage) {
 }
 
 TestHttpServer::~TestHttpServer() {
@@ skipping 61 matching lines @@
     case kAccept:
       server_->AcceptWebSocket(connection_id, info);
       break;
     case kNotFound:
       server_->Send404(connection_id);
       break;
     case kClose:
       // net::HttpServer doesn't allow us to close connection during callback.
       base::MessageLoop::current()->PostTask(
           FROM_HERE,
-          base::Bind(&net::HttpServer::Close, server_, connection_id));
+          base::Bind(&net::HttpServer::Close, server_->AsWeakPtr(),
+                     connection_id));
       break;
   }
 }
 
 void TestHttpServer::OnWebSocketMessage(int connection_id,
                                         const std::string& data) {
   WebSocketMessageAction action;
   {
     base::AutoLock lock(action_lock_);
     action = message_action_;
   }
   switch (action) {
     case kEchoMessage:
       server_->SendOverWebSocket(connection_id, data);
       break;
     case kCloseOnMessage:
       // net::HttpServer doesn't allow us to close connection during callback.
       base::MessageLoop::current()->PostTask(
           FROM_HERE,
-          base::Bind(&net::HttpServer::Close, server_, connection_id));
+          base::Bind(&net::HttpServer::Close, server_->AsWeakPtr(),
+                     connection_id));
       break;
   }
 }
 
 void TestHttpServer::OnClose(int connection_id) {
   connections_.erase(connection_id);
   if (connections_.empty())
     all_closed_event_.Signal();
 }
 
 void TestHttpServer::StartOnServerThread(bool* success,
                                          base::WaitableEvent* event) {
-  net::TCPListenSocketFactory factory("127.0.0.1", 0);
-  server_ = new net::HttpServer(factory, this);
+  server_.reset(net::HttpServer::Create("127.0.0.1", 0, this));
+  EXPECT_NE(NULL, server_.get());

[mmenke, 2014/05/23 19:20:58]

If this fails, we'll crash 2 lines down.

Suggest:

*success = false;
ASSERT_NE(...)

[byungchul, 2014/05/30 00:19:02]

Removed.

 
   net::IPEndPoint address;
   int error = server_->GetLocalAddress(&address);
   EXPECT_EQ(net::OK, error);
   if (error == net::OK) {
     base::AutoLock lock(url_lock_);
     web_socket_url_ = GURL(base::StringPrintf("ws://127.0.0.1:%d",
                                               address.port()));
   } else {
-    server_ = NULL;
+    server_.reset(NULL);
   }
   *success = server_.get();
   event->Signal();
 }
 
 void TestHttpServer::StopOnServerThread(base::WaitableEvent* event) {
-  if (server_.get())
-    server_ = NULL;
+  server_.reset(NULL);
   event->Signal();
 }