Start and stop the GCM service on demand

Start and stop the GCM service on demand

The GCM service will now be started when there is a consumer. It will be
automatically stopped when all consumers are gone. This does not change
the existing behavior that the GCM is always started for the signed-in
profile since invalidation consumes it.

BUG=356716
TEST=tests updated and new tests added
TBR=kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272380

[Nicolas Zea, 2014-05-22 17:06:31]

gcm LGTM with a couple comments

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:707: // Has any app requested the
service?
nit: has -> Have

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_profile_service_unittest.cc (right):

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_profile_service_unittest.cc:129:
profile_.reset();
why is this necessary? profile_ is going to be destroyed anyways

[fgorski, 2014-05-22 17:56:42]

lgtm mod the profile reset (following Nicolas's comment)

[jianli, 2014-05-22 18:09:26]

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_driver.cc (right):

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_driver.cc:707: // Has any app requested the
service?
On 2014/05/22 17:06:31, Nicolas Zea wrote:
> nit: has -> Have

Done.

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_profile_service_unittest.cc (right):

https://codereview.chromium.org/296053011/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_profile_service_unittest.cc:129:
profile_.reset();
On 2014/05/22 17:06:31, Nicolas Zea wrote:
> why is this necessary? profile_ is going to be destroyed anyways

Yes, it is not needed. I forgot to remove app handler here.

[jianli, 2014-05-22 18:11:45]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-05-22 18:13:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/296053011/20001

[jianli, 2014-05-22 20:38:57]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2014-05-22 20:39:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jianli@chromium.org/296053011/40001

[commit-bot: I haz the power, 2014-05-23 00:25:45]

Change committed as 272380