Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296053009: Makes Env contain a ContextFactory (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, ben+aura_chromium.org, miu+watch_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, kalyank, piman+watch_chromium.org, jochen+watch_chromium.org, plundblad+watch_chromium.org, tfarina, ben+corewm_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, ben+ash_chromium.org
Visibility:
Public.

Description

Makes Env contain a ContextFactory This way when creating the Compositor we can supply the ContextFactory from the thread local Env to it. This is part of making aura thread safe. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272332

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix demo main #

Patch Set 4 : fix test #

Patch Set 5 : fix viewseventtestbase #

Patch Set 6 : Fix MojoTreeHostMojo #

Patch Set 7 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -69 lines) Patch
M apps/shell/browser/shell_desktop_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/shell.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell_init_params.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/shell_init_params.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ash/test/ash_test_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_views.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/env.h View 3 chunks +8 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/test_views_delegate.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 2 chunks +1 line, -11 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/test/views_test_helper.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper_aura.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/wm/test/wm_test_helper.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
I think this is ready for review.
6 years, 7 months ago (2014-05-22 14:00:29 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-22 17:18:46 UTC) #2
sky
6 years, 7 months ago (2014-05-22 21:48:04 UTC) #3
Message was sent while issue was closed. 
Committed patchset #7 manually as r272332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698