Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/browser/search_engines/template_url_service.h

Issue 296053007: Don't report origin changes during loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix formatting. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
6 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 6 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 // All changes that don't fall into another category; we can't reorder the 455 // All changes that don't fall into another category; we can't reorder the
456 // list for clarity as this would screw up stat collection. 456 // list for clarity as this would screw up stat collection.
457 DSP_CHANGE_OTHER, 457 DSP_CHANGE_OTHER,
458 // Changed through "Profile Reset" feature. 458 // Changed through "Profile Reset" feature.
459 DSP_CHANGE_PROFILE_RESET, 459 DSP_CHANGE_PROFILE_RESET,
460 // Changed by an extension through the Override Settings API. 460 // Changed by an extension through the Override Settings API.
461 DSP_CHANGE_OVERRIDE_SETTINGS_EXTENSION, 461 DSP_CHANGE_OVERRIDE_SETTINGS_EXTENSION,
462 // New DSP during database/prepopulate data load, which was not previously 462 // New DSP during database/prepopulate data load, which was not previously
463 // in the known engine set, and with no previous value in prefs. The 463 // in the known engine set, and with no previous value in prefs. The
464 // typical time to see this is during first run. 464 // typical time to see this is during first run.
465 DSP_CHANGE_NEW_ENGINE_NO_PREFS, 465 DSP_CHANGE_NEW_ENGINE_NO_PREFS,
Peter Kasting 2014/05/21 19:38:41 This value no longer seems to be in use. Maybe it
erikwright (departed) 2014/05/21 20:38:48 Several of the values are unused now. I can remove
Peter Kasting 2014/05/21 20:45:13 That still seems preferable. OK to do it separate
466 // The DSP value is being applied while loading preferences from disk. This
467 // is not actually a change (we don't report this).
468 DSP_CHANGE_INITIAL_LOAD,
466 // Boundary value. 469 // Boundary value.
467 DSP_CHANGE_MAX, 470 DSP_CHANGE_MAX,
468 }; 471 };
469 472
470 // Helper functor for FindMatchingKeywords(), for finding the range of 473 // Helper functor for FindMatchingKeywords(), for finding the range of
471 // keywords which begin with a prefix. 474 // keywords which begin with a prefix.
472 class LessWithPrefix; 475 class LessWithPrefix;
473 476
474 void Init(const Initializer* initializers, int num_initializers); 477 void Init(const Initializer* initializers, int num_initializers);
475 478
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 782
780 scoped_ptr<GoogleURLTracker::Subscription> google_url_updated_subscription_; 783 scoped_ptr<GoogleURLTracker::Subscription> google_url_updated_subscription_;
781 784
782 // Used to disable the prepopulated search engines in tests. 785 // Used to disable the prepopulated search engines in tests.
783 static bool g_fallback_search_engines_disabled; 786 static bool g_fallback_search_engines_disabled;
784 787
785 DISALLOW_COPY_AND_ASSIGN(TemplateURLService); 788 DISALLOW_COPY_AND_ASSIGN(TemplateURLService);
786 }; 789 };
787 790
788 #endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 791 #endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698