Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 296053005: Fix more cases of unreachable code on Windows (Closed)

Created:
6 years, 7 months ago by Peter Kasting
Modified:
6 years, 7 months ago
Reviewers:
oshima, jam, justincohen
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, chromium-apps-reviews_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, ben+ash_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Fix more cases of unreachable code on Windows, mostly added recently. BUG=346399 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
oshima: ash/ OWNERS jam: chrome/, content/, and pdf/ OWNERS justincohen (newt is OOO): components/ OWNERS. ...
6 years, 7 months ago (2014-05-20 21:50:39 UTC) #1
oshima
ash/ lgtm thank you for cleanup.
6 years, 7 months ago (2014-05-20 21:56:52 UTC) #2
justincohen
lgtm
6 years, 7 months ago (2014-05-20 22:55:56 UTC) #3
jam
lgtm
6 years, 7 months ago (2014-05-21 16:46:10 UTC) #4
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 7 months ago (2014-05-21 19:27:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/296053005/1
6 years, 7 months ago (2014-05-21 19:58:32 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:21:45 UTC) #7
Message was sent while issue was closed.
Change committed as 272069

Powered by Google App Engine
This is Rietveld 408576698