Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 296053004: Removed privledged and debug webgl extension handling. (Closed)

Created:
6 years, 7 months ago by bajones
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, aandrey+blink_chromium.org
Visibility:
Public.

Description

Removed privledged and debug webgl extension handling. These extensions should be on all the time. Dependent on https://codereview.chromium.org/292983005/ BUG=375383 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -54 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 4 chunks +1 line, -26 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bajones
jamesr@: Please review flag removal in Source/web and public/web kbr@: Please review Extensions logic changes ...
6 years, 7 months ago (2014-05-20 18:49:45 UTC) #1
Ken Russell (switch to Gerrit)
Good cleanup. LGTM
6 years, 7 months ago (2014-05-20 19:30:05 UTC) #2
Ken Russell (switch to Gerrit)
+abarth and dglazkov for public/ OWNERS
6 years, 7 months ago (2014-05-20 19:31:08 UTC) #3
bajones
On 2014/05/20 19:31:08, Ken Russell wrote: > +abarth and dglazkov for public/ OWNERS Review ping ...
6 years, 7 months ago (2014-05-21 18:53:15 UTC) #4
bajones
On 2014/05/21 18:53:15, bajones wrote: > On 2014/05/20 19:31:08, Ken Russell wrote: > > +abarth ...
6 years, 7 months ago (2014-05-27 18:00:18 UTC) #5
dglazkov
lgtm
6 years, 7 months ago (2014-05-27 18:30:40 UTC) #6
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 7 months ago (2014-05-27 18:31:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/296053004/1
6 years, 7 months ago (2014-05-27 18:31:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 7 months ago (2014-05-27 20:29:07 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 22:15:50 UTC) #10
Message was sent while issue was closed.
Change committed as 174903

Powered by Google App Engine
This is Rietveld 408576698