cc: Add UniqueNotifier to cc/base.

cc/base/unique_notifier_unittest.cc

Index: cc/base/unique_notifier_unittest.cc
diff --git a/cc/base/unique_notifier_unittest.cc b/cc/base/unique_notifier_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..876ccfc1684e71f8850837c9827d3a35e7dcf992
--- /dev/null
+++ b/cc/base/unique_notifier_unittest.cc
@@ -0,0 +1,78 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
+#include "cc/base/unique_notifier.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace cc {
+namespace {
+
+class UniqueNotifierTest : public testing::Test {
+ public:
+  UniqueNotifierTest() : notification_count_(0) {}
+
+  virtual void SetUp() OVERRIDE {
+    task_runner_ = base::MessageLoopProxy::current();
+    ResetNotificationCount();
+  }
+
+  virtual void TearDown() OVERRIDE {
+    notifier_.reset();
+    task_runner_ = NULL;
+  }
+
+  void Notify() { ++notification_count_; }
+
+  int NotificationCount() const { return notification_count_; }
+
+  void ResetNotificationCount() { notification_count_ = 0; }
+
+  void RunUntilIdle() {
+    run_loop_ = make_scoped_ptr(new base::RunLoop);
+    task_runner_->PostTask(FROM_HERE, run_loop_->QuitClosure());
+    run_loop_->Run();

[reveman, 2014/05/21 18:08:31]

I think you can replace all this with:
base::RunLoop().RunUntilIdle();
and remove both task_runner_ and run_loop_ from this class.

[vmpstr, 2014/05/21 18:54:54]

Done.

+  }
+
+ protected:
+  int notification_count_;
+  scoped_ptr<UniqueNotifier> notifier_;
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
+  scoped_ptr<base::RunLoop> run_loop_;
+};
+
+TEST_F(UniqueNotifierTest, Schedule) {
+  notifier_ = make_scoped_ptr(new UniqueNotifier(

[reveman, 2014/05/21 18:08:31]

Can you put this on the stack instead and remove UniqueNotifierTest::notifier_?

[vmpstr, 2014/05/21 18:54:54]

Done.

+      task_runner_.get(),
+      base::Bind(&UniqueNotifierTest::Notify, base::Unretained(this))));
+
+  EXPECT_EQ(0, NotificationCount());
+
+  // Basic schedule should result in a run.
+  notifier_->Schedule();
+
+  RunUntilIdle();
+  EXPECT_EQ(1, NotificationCount());
+
+  // Multiple schedules should only result in one run.
+  for (int i = 0; i < 5; ++i)
+    notifier_->Schedule();
+
+  RunUntilIdle();
+  EXPECT_EQ(2, NotificationCount());
+
+  // Schedule and notifier going away should not result in any runs.
+  notifier_->Schedule();

[reveman, 2014/05/21 19:42:45]

I liked this part of test. Could you keep it in latest patch by having the
notifier go out of scope here?

+  notifier_.reset();
+
+  RunUntilIdle();
+  EXPECT_EQ(2, NotificationCount());
+}
+
+}  // namespace
+}  // namespace cc