Issue 296043004: Fix UnboundScript::GetScriptName and GetLineNumber.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296043004: Fix UnboundScript::GetScriptName and GetLineNumber. (Closed)

Created:
6 years, 7 months ago by marja

Modified:
6 years, 7 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix UnboundScript::GetScriptName and GetLineNumber. Probably broken since r19925 (mine). R=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21398

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
	M	src/api.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

marja

dcarney, ptal Afaics, I broke this when I split Script and UnboundScript; I put GetScriptName ...

6 years, 7 months ago (2014-05-20 17:14:02 UTC) #1

marja

6 years, 7 months ago (2014-05-21 07:32:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r21398 (presubmit successful).