Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 296043002: Remove special debug ExternalReferences. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Remove special debug ExternalReferences. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -69 lines) Patch
M src/arm/debug-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/debug-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/assembler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/assembler.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M src/debug.h View 2 chunks +5 lines, -37 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/debug-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/serialize.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/serialize.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-05-20 15:19:12 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-05-22 07:37:12 UTC) #2
Yang
6 years, 7 months ago (2014-05-22 07:58:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21421 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698