Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

runtime/lib/regexp.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/regexp_parser.h"
 #include "vm/regexp_assembler_ir.h"
 #include "vm/regexp_assembler_bytecode.h"
 #include "vm/thread.h"
 
 namespace dart {
 
-DECLARE_FLAG(bool, trace_irregexp);
+DEFINE_FLAG(bool, trace_irregexp, false, "Trace irregexps");
 
 
 DEFINE_NATIVE_ENTRY(RegExp_factory, 4) {
   ASSERT(TypeArguments::CheckedHandle(arguments->NativeArgAt(0)).IsNull());
   GET_NON_NULL_NATIVE_ARGUMENT(String, pattern, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, handle_multi_line,
                                arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, handle_case_sensitive,
                                arguments->NativeArgAt(3));
   bool ignore_case = handle_case_sensitive.raw() != Bool::True().raw();
@@ skipping 51 matching lines @@
 
 
 static RawObject* ExecuteMatch(Zone* zone,
                                NativeArguments* arguments,
                                bool sticky) {
   const RegExp& regexp = RegExp::CheckedHandle(arguments->NativeArgAt(0));
   ASSERT(!regexp.IsNull());
   GET_NON_NULL_NATIVE_ARGUMENT(String, subject, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, start_index, arguments->NativeArgAt(2));
 
-  if (FLAG_interpret_irregexp) {
-    return BytecodeRegExpMacroAssembler::Interpret(regexp, subject, start_index,
-                                                   /*sticky=*/sticky, zone);
+#if !defined(DART_PRECOMPILED_RUNTIME)

[rmacnak, 2017/07/10 17:50:00]

Not in this CL, but we should consider unburdening the non-DBC JIT of the
interpreter too.

[Aske Simon Christensen, 2017/07/11 09:11:56]

It would still be available via the commandline flag. I think it can be
practical to have both to switch between when debugging regexp engine issues.

+  if (!FLAG_interpret_irregexp) {
+    return IRRegExpMacroAssembler::Execute(regexp, subject, start_index,
+                                           /*sticky=*/sticky, zone);
   }
-
-  return IRRegExpMacroAssembler::Execute(regexp, subject, start_index,
-                                         /*sticky=*/sticky, zone);
+#endif
+  return BytecodeRegExpMacroAssembler::Interpret(regexp, subject, start_index,
+                                                 /*sticky=*/sticky, zone);
 }
 
 
 DEFINE_NATIVE_ENTRY(RegExp_ExecuteMatch, 3) {
   // This function is intrinsified. See Intrinsifier::RegExp_ExecuteMatch.
   return ExecuteMatch(zone, arguments, /*sticky=*/false);
 }
 
 
 DEFINE_NATIVE_ENTRY(RegExp_ExecuteMatchSticky, 3) {
   // This function is intrinsified. See Intrinsifier::RegExp_ExecuteMatchSticky.
   return ExecuteMatch(zone, arguments, /*sticky=*/true);
 }
 
 
 }  // namespace dart