Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a dependency on locations.cc, which is part of the compiler.


BUG= https://github.com/dart-lang/sdk/issues/30045
R=rmacnak@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/ab7d9a57205a6cf2004776e8f16e4bf85ddf6c69

[Aske Simon Christensen, 2017-06-29 15:42:45]

Description was changed from

==========
JIT compiler not included in precompiled runtime on ARM64.

BUG=
==========

to

==========
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This
requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a
dependency on locations.cc, which is part of the compiler.


BUG=https://github.com/dart-lang/sdk/issues/30045
==========

[Aske Simon Christensen, 2017-06-29 15:42:45]

askesc@google.com changed reviewers:
+ vegorov@google.com, zra@google.com

[Aske Simon Christensen, 2017-06-29 15:44:51]

Description was changed from

==========
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This
requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a
dependency on locations.cc, which is part of the compiler.


BUG=https://github.com/dart-lang/sdk/issues/30045
==========

to

==========
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This
requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a
dependency on locations.cc, which is part of the compiler.


BUG= https://github.com/dart-lang/sdk/issues/30045
==========

[zra, 2017-06-30 00:07:00]

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor.cc
File runtime/vm/program_visitor.cc (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor....
runtime/vm/program_visitor.cc:613: DedupDeoptEntries();
You can use the NOT_IN_PRECOMPILED() macro for single-line exclusions:

NOT_IN_PRECOMPILED(DedupDeoptEntries());

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor.h
File runtime/vm/program_visitor.h (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor....
runtime/vm/program_visitor.h:37: static void DedupDeoptEntries();
NOT_IN_PRECOMPILED(static void DedupDeoptEntries());

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/regexp.h
File runtime/vm/regexp.h (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/regexp.h#newcode...
runtime/vm/regexp.h:1393: IndirectGotoInstr* backtrack_goto;
In other files it looks like we use the NOT_IN_PRECOMPILED() macro for fields
that are excluded.

[Aske Simon Christensen, 2017-07-03 13:41:08]

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor.cc
File runtime/vm/program_visitor.cc (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor....
runtime/vm/program_visitor.cc:613: DedupDeoptEntries();
On 2017/06/30 00:07:00, zra wrote:
> You can use the NOT_IN_PRECOMPILED() macro for single-line exclusions:
> 
> NOT_IN_PRECOMPILED(DedupDeoptEntries());

Done.

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor.h
File runtime/vm/program_visitor.h (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/program_visitor....
runtime/vm/program_visitor.h:37: static void DedupDeoptEntries();
On 2017/06/30 00:07:00, zra wrote:
> NOT_IN_PRECOMPILED(static void DedupDeoptEntries());

Done.

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/regexp.h
File runtime/vm/regexp.h (right):

https://codereview.chromium.org/2960413002/diff/1/runtime/vm/regexp.h#newcode...
runtime/vm/regexp.h:1393: IndirectGotoInstr* backtrack_goto;
On 2017/06/30 00:07:00, zra wrote:
> In other files it looks like we use the NOT_IN_PRECOMPILED() macro for fields
> that are excluded.

Done.

[zra, 2017-07-10 16:07:10]

zra@google.com changed reviewers:
+ rmacnak@google.com

[zra, 2017-07-10 16:07:11]

lgtm but I think rmacnak should take a look as well.

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/regexp_assem...
File runtime/vm/regexp_assembler_ir.cc (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/regexp_assem...
runtime/vm/regexp_assembler_ir.cc:40: DECLARE_FLAG(bool, trace_irregexp);
Can this flag be moved to flag_list.h?

[rmacnak, 2017-07-10 17:50:01]

lgtm

https://codereview.chromium.org/2960413002/diff/20001/runtime/lib/regexp.cc
File runtime/lib/regexp.cc (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/lib/regexp.cc#n...
runtime/lib/regexp.cc:89: #if !defined(DART_PRECOMPILED_RUNTIME)
Not in this CL, but we should consider unburdening the non-DBC JIT of the
interpreter too.

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/program_visi...
File runtime/vm/program_visitor.h (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/program_visi...
runtime/vm/program_visitor.h:25: class ProgramVisitor : public AllStatic {
This shouldn't be used at all in AOT.

[Aske Simon Christensen, 2017-07-11 09:11:56]

I will land this CL and then upload a new one for the assembler/stub changes.

https://codereview.chromium.org/2960413002/diff/20001/runtime/lib/regexp.cc
File runtime/lib/regexp.cc (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/lib/regexp.cc#n...
runtime/lib/regexp.cc:89: #if !defined(DART_PRECOMPILED_RUNTIME)
On 2017/07/10 17:50:00, rmacnak wrote:
> Not in this CL, but we should consider unburdening the non-DBC JIT of the
> interpreter too.

It would still be available via the commandline flag. I think it can be
practical to have both to switch between when debugging regexp engine issues.

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/program_visi...
File runtime/vm/program_visitor.h (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/program_visi...
runtime/vm/program_visitor.h:25: class ProgramVisitor : public AllStatic {
On 2017/07/10 17:50:00, rmacnak wrote:
> This shouldn't be used at all in AOT.

OK, I will take a look at eliminating this as part of the next CL for the issue.

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/regexp_assem...
File runtime/vm/regexp_assembler_ir.cc (right):

https://codereview.chromium.org/2960413002/diff/20001/runtime/vm/regexp_assem...
runtime/vm/regexp_assembler_ir.cc:40: DECLARE_FLAG(bool, trace_irregexp);
On 2017/07/10 16:07:10, zra wrote:
> Can this flag be moved to flag_list.h?

Done. I marked the flag as type C, since it is not working for interpreted
regexps anyway, and is presumably not useful in product builds.

[Aske Simon Christensen, 2017-07-11 10:02:16]

Description was changed from

==========
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This
requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a
dependency on locations.cc, which is part of the compiler.


BUG= https://github.com/dart-lang/sdk/issues/30045
==========

to

==========
Omit JIT compiler from precompiled runtime on ARM, ARM64 and IA32.

Saves about a megabyte on the size of the precompiled runtime VM.

Next step will be to eliminate the assemblers and code stubs as well. This
requires some more disentangling.

Until then, the X64 build still includes the compiler, since its assembler has a
dependency on locations.cc, which is part of the compiler.


BUG= https://github.com/dart-lang/sdk/issues/30045
R=rmacnak@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ab7d9a57205a6cf2004776e8f16e4bf85ddf6c69
==========

[Aske Simon Christensen, 2017-07-11 10:02:18]

Committed patchset #3 (id:40001) manually as
ab7d9a57205a6cf2004776e8f16e4bf85ddf6c69 (presubmit successful).