Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: services/service_manager/public/cpp/service_context_ref.cc

Issue 2960373002: Rename TaskRunner::RunsTasksOnCurrentThread() in //service, //components (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/service_manager/embedder/embedded_service_runner.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/service_manager/public/cpp/service_context_ref.h" 5 #include "services/service_manager/public/cpp/service_context_ref.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/sequence_checker.h" 10 #include "base/sequence_checker.h"
11 #include "base/sequenced_task_runner.h" 11 #include "base/sequenced_task_runner.h"
12 #include "base/threading/sequenced_task_runner_handle.h" 12 #include "base/threading/sequenced_task_runner_handle.h"
13 13
14 namespace service_manager { 14 namespace service_manager {
15 15
16 class ServiceContextRefImpl : public ServiceContextRef { 16 class ServiceContextRefImpl : public ServiceContextRef {
17 public: 17 public:
18 ServiceContextRefImpl( 18 ServiceContextRefImpl(
19 base::WeakPtr<ServiceContextRefFactory> factory, 19 base::WeakPtr<ServiceContextRefFactory> factory,
20 scoped_refptr<base::SequencedTaskRunner> service_task_runner) 20 scoped_refptr<base::SequencedTaskRunner> service_task_runner)
21 : factory_(factory), service_task_runner_(service_task_runner) { 21 : factory_(factory), service_task_runner_(service_task_runner) {
22 // This object is not thread-safe but may be used exclusively on a different 22 // This object is not thread-safe but may be used exclusively on a different
23 // thread from the one which constructed it. 23 // thread from the one which constructed it.
24 DETACH_FROM_SEQUENCE(sequence_checker_); 24 DETACH_FROM_SEQUENCE(sequence_checker_);
25 } 25 }
26 26
27 ~ServiceContextRefImpl() override { 27 ~ServiceContextRefImpl() override {
28 DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); 28 DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
29 29
30 if (service_task_runner_->RunsTasksOnCurrentThread() && factory_) { 30 if (service_task_runner_->RunsTasksInCurrentSequence() && factory_) {
31 factory_->Release(); 31 factory_->Release();
32 } else { 32 } else {
33 service_task_runner_->PostTask( 33 service_task_runner_->PostTask(
34 FROM_HERE, base::Bind(&ServiceContextRefFactory::Release, factory_)); 34 FROM_HERE, base::Bind(&ServiceContextRefFactory::Release, factory_));
35 } 35 }
36 } 36 }
37 37
38 private: 38 private:
39 // ServiceContextRef: 39 // ServiceContextRef:
40 std::unique_ptr<ServiceContextRef> Clone() override { 40 std::unique_ptr<ServiceContextRef> Clone() override {
41 DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); 41 DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
42 42
43 if (service_task_runner_->RunsTasksOnCurrentThread() && factory_) { 43 if (service_task_runner_->RunsTasksInCurrentSequence() && factory_) {
44 factory_->AddRef(); 44 factory_->AddRef();
45 } else { 45 } else {
46 service_task_runner_->PostTask( 46 service_task_runner_->PostTask(
47 FROM_HERE, base::Bind(&ServiceContextRefFactory::AddRef, factory_)); 47 FROM_HERE, base::Bind(&ServiceContextRefFactory::AddRef, factory_));
48 } 48 }
49 49
50 return base::MakeUnique<ServiceContextRefImpl>(factory_, 50 return base::MakeUnique<ServiceContextRefImpl>(factory_,
51 service_task_runner_); 51 service_task_runner_);
52 } 52 }
53 53
(...skipping 21 matching lines...) Expand all
75 void ServiceContextRefFactory::AddRef() { 75 void ServiceContextRefFactory::AddRef() {
76 ++ref_count_; 76 ++ref_count_;
77 } 77 }
78 78
79 void ServiceContextRefFactory::Release() { 79 void ServiceContextRefFactory::Release() {
80 if (!--ref_count_) 80 if (!--ref_count_)
81 quit_closure_.Run(); 81 quit_closure_.Run();
82 } 82 }
83 83
84 } // namespace service_manager 84 } // namespace service_manager
OLDNEW
« no previous file with comments | « services/service_manager/embedder/embedded_service_runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698