Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 296033003: ozone: views: Fix menu_controller_unittest test build (Closed)

Created:
6 years, 7 months ago by spang
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

ozone: views: Fix menu_controller_unittest test build BUG=none TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271758

Patch Set 1 #

Total comments: 2

Patch Set 2 : add #error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M ui/views/controls/menu/menu_controller_unittest.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
spang
is this right?
6 years, 7 months ago (2014-05-20 14:25:24 UTC) #1
sadrul
https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc File ui/views/controls/menu/menu_controller_unittest.cc (right): https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc#newcode95 ui/views/controls/menu/menu_controller_unittest.cc:95: #endif #error out on #else?
6 years, 7 months ago (2014-05-20 16:16:48 UTC) #2
sadrul
On 2014/05/20 16:16:48, sadrul wrote: > https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc > File ui/views/controls/menu/menu_controller_unittest.cc (right): > > https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc#newcode95 > ...
6 years, 7 months ago (2014-05-20 16:18:08 UTC) #3
spang
https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc File ui/views/controls/menu/menu_controller_unittest.cc (right): https://codereview.chromium.org/296033003/diff/1/ui/views/controls/menu/menu_controller_unittest.cc#newcode95 ui/views/controls/menu/menu_controller_unittest.cc:95: #endif On 2014/05/20 16:16:49, sadrul wrote: > #error out ...
6 years, 7 months ago (2014-05-20 16:30:40 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 7 months ago (2014-05-20 16:30:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/296033003/20001
6 years, 7 months ago (2014-05-20 16:31:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 19:09:28 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:32:22 UTC) #8
Message was sent while issue was closed.
Change committed as 271758

Powered by Google App Engine
This is Rietveld 408576698