Issue 2960303003: dart2js kernel: Rewrite logical expression trees to short-circuit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2960303003: dart2js kernel: Rewrite logical expression trees to short-circuit (Closed)

Created:
3 years, 5 months ago by sra1

Modified:
3 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js kernel: Rewrite logical expression trees to short-circuit The Ast builder does this, so it makes the comparison of generated code easier. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6651f58674b558a7da465635b494341294da6b6b

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View		1 chunk	+32 lines, -3 lines	0 comments	Download

Total messages: 7 (4 generated)

sra1

3 years, 5 months ago (2017-06-29 18:26:19 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:40001) manually as
6651f58674b558a7da465635b494341294da6b6b (presubmit successful).