| OLD | NEW |
|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html ng-app="Loader" ng-controller="Loader.Controller"> | 3 <html ng-app="Loader" ng-controller="Loader.Controller"> |
| 4 | 4 |
| 5 <head> | 5 <head> |
| 6 <title ng-bind="windowTitle"></title> | 6 <title ng-bind="windowTitle"></title> |
| 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"
></script> | 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js"
></script> |
| 8 <script src="loader.js"></script> | 8 <script src="loader.js"></script> |
| 9 <link rel="stylesheet" href="view.css"> | |
| 10 </head> | 9 </head> |
| 11 | 10 |
| 12 <body> | 11 <body> |
| 13 <em> | 12 <em> |
| 14 {{loadingMessage}} | 13 {{loadingMessage}} |
| 15 </em> | 14 </em> |
| 16 | 15 |
| 17 <div ng-hide="!categories"><!-- everything: hide until data is loaded --> | 16 <div ng-hide="!categories"> |
| 18 | |
| 19 <div ng-hide="!(header.isEditable && header.isExported)" | 17 <div ng-hide="!(header.isEditable && header.isExported)" |
| 20 style="background-color:#ffbb00"> | 18 style="background-color:#ffbb00"> |
| 21 WARNING! These results are editable and exported, so any user | 19 WARNING! These results are editable and exported, so any user |
| 22 who can connect to this server over the network can modify them. | 20 who can connect to this server over the network can modify them. |
| 23 </div> | 21 </div> |
| 24 | |
| 25 <div style="background-color:#bbffbb"><!-- TODOs --> | |
| 26 <p> | |
| 27 TODO(epoger): | |
| 28 <input type="checkbox" name="showTodosCheckbox" value="true" | |
| 29 ng-checked="showTodos == true" | |
| 30 ng-click="showTodos = !showTodos"> | |
| 31 show | |
| 32 <ul ng-hide="!showTodos"> | |
| 33 <li> | |
| 34 Implement editing of results (we have added the --editable | |
| 35 flag to the server, but it's not fully implemented yet). | |
| 36 <div ng-hide="!header.isEditable"> | |
| 37 Currently selected items are: {{selectedItems}} | |
| 38 </div> | |
| 39 </li><li> | |
| 40 If server was run with --reload flag, automatically check for | |
| 41 new results and tell the user when new results are available | |
| 42 (the user can reload the page if he wants to see them). | |
| 43 </li><li> | |
| 44 Add ability to filter builder and test names | |
| 45 (using a free-form text field, with partial string match) | |
| 46 </li><li> | |
| 47 Add more columns, such as pixel diffs, notes/bugs, | |
| 48 ignoreFailure boolean | |
| 49 </li><li> | |
| 50 Improve the column sorting, as per | |
| 51 <a href="http://jsfiddle.net/vojtajina/js64b/14/"> | |
| 52 http://jsfiddle.net/vojtajina/js64b/14/ | |
| 53 </a> | |
| 54 </li><li> | |
| 55 Right now, if you change which column is used to | |
| 56 sort the data, the column widths may fluctuate based on the | |
| 57 longest string <i>currently visible</i> within the top {{displayLimit}
} | |
| 58 results. Can we fix the column widths to be wide enough to hold | |
| 59 any result, even the currently hidden results? | |
| 60 </li> | |
| 61 </ul> | |
| 62 </div><!-- TODOs --> | |
| 63 | |
| 64 <div ng-hide="!(header.timeUpdated)"> | 22 <div ng-hide="!(header.timeUpdated)"> |
| 65 Results current as of {{localTimeString(header.timeUpdated)}} | 23 Results current as of {{localTimeString(header.timeUpdated)}} |
| 66 </div> | 24 </div> |
| 67 | 25 <table border="1"> |
| 68 <div style="font-size:20px"><!-- tabs --> | |
| 69 <div ng-repeat="disposition in dispositions" | |
| 70 style="display:inline-block"> | |
| 71 <div class="disposition-tab-{{disposition == viewingDisposition}}" | |
| 72 style="display:inline-block" | |
| 73 ng-click="setViewingDisposition(disposition)"> | |
| 74 {{disposition}} | |
| 75 </div> | |
| 76 <div style="display:inline-block"> | |
| 77 | |
| 78 </div> | |
| 79 </div> | |
| 80 </div><!-- tabs --> | |
| 81 | |
| 82 <div class="disposition-tab-true"><!-- display of current disposition type -
-> | |
| 83 | |
| 84 <br> | |
| 85 <table ng-hide="viewingDisposition != defaultDisposition" border="1"> | |
| 86 <tr> | 26 <tr> |
| 87 <th colspan="2"> | 27 <th colspan="2"> |
| 88 Filters | 28 Filters |
| 89 </th> | 29 </th> |
| 90 <th> | 30 <th> |
| 91 Settings | 31 Settings |
| 92 </th> | 32 </th> |
| 93 </tr> | 33 </tr> |
| 94 <tr valign="top"> | 34 <tr valign="top"> |
| 95 <td> | 35 <td> |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 133 <button style="font-size:30px" | 73 <button style="font-size:30px" |
| 134 ng-click="updateResults()" | 74 ng-click="updateResults()" |
| 135 ng-disabled="!areUpdatesPending"> | 75 ng-disabled="!areUpdatesPending"> |
| 136 Update Results | 76 Update Results |
| 137 </button> | 77 </button> |
| 138 </td></tr> | 78 </td></tr> |
| 139 </tr></table></td> | 79 </tr></table></td> |
| 140 </tr> | 80 </tr> |
| 141 </table> | 81 </table> |
| 142 | 82 |
| 83 <p> |
| 84 TODO(epoger): |
| 85 <input type="checkbox" name="showTodosCheckbox" value="true" |
| 86 ng-checked="showTodos == true" |
| 87 ng-click="showTodos = !showTodos"> |
| 88 show |
| 89 <ul ng-hide="!showTodos"> |
| 90 <li> |
| 91 Implement editing of results (we have added the --editable |
| 92 flag to the server, but it's not fully implemented yet). |
| 93 <div ng-hide="!header.isEditable"> |
| 94 Currently selected items are: {{selectedItems}} |
| 95 </div> |
| 96 </li><li> |
| 97 If server was run with --reload flag, automatically check for |
| 98 new results and tell the user when new results are available |
| 99 (the user can reload the page if he wants to see them). |
| 100 </li><li> |
| 101 Add ability to filter builder and test names |
| 102 (using a free-form text field, with partial string match) |
| 103 </li><li> |
| 104 Add more columns, such as pixel diffs, notes/bugs, |
| 105 ignoreFailure boolean |
| 106 </li><li> |
| 107 Improve the column sorting, as per |
| 108 <a href="http://jsfiddle.net/vojtajina/js64b/14/"> |
| 109 http://jsfiddle.net/vojtajina/js64b/14/ |
| 110 </a> |
| 111 </li><li> |
| 112 Right now, if you change which column is used to |
| 113 sort the data, the column widths may fluctuate based on the |
| 114 longest string <i>currently visible</i> within the top {{displayLimit}
} |
| 115 results. Can we fix the column widths to be wide enough to hold |
| 116 any result, even the currently hidden results? |
| 117 </li> |
| 118 </ul> |
| 143 <p> | 119 <p> |
| 144 Found {{filteredTestData.length}} matches; | 120 Found {{filteredTestData.length}} matches, and displaying the first |
| 145 <span ng-hide="filteredTestData.length <= limitedTestData.length"> | 121 {{displayLimit}}: <br> |
| 146 displaying the first {{limitedTestData.length}} | 122 <!-- TODO(epoger): If (displayLimit <= filteredTestData.length), |
| 147 </span> | 123 modify this message to indicate that all results are shown. --> |
| 148 <span ng-hide="filteredTestData.length > limitedTestData.length"> | |
| 149 displaying them all | |
| 150 </span> | |
| 151 <br> | |
| 152 | |
| 153 (click on the column header radio buttons to re-sort by that column) | 124 (click on the column header radio buttons to re-sort by that column) |
| 154 <br> | 125 <br> |
| 155 | |
| 156 <table border="1"> | 126 <table border="1"> |
| 157 <tr> | 127 <tr> |
| 158 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf
ig']"> | 128 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf
ig']"> |
| 159 <input type="radio" | 129 <input type="radio" |
| 160 name="sortColumnRadio" | 130 name="sortColumnRadio" |
| 161 value="{{categoryName}}" | 131 value="{{categoryName}}" |
| 162 ng-checked="(sortColumn == categoryName)" | 132 ng-checked="(sortColumn == categoryName)" |
| 163 ng-click="sortResultsBy(categoryName)"> | 133 ng-click="sortResultsBy(categoryName)"> |
| 164 {{categoryName}} | 134 {{categoryName}} |
| 165 </th> | 135 </th> |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 199 </a> | 169 </a> |
| 200 </td> | 170 </td> |
| 201 <td ng-hide="!header.isEditable"> | 171 <td ng-hide="!header.isEditable"> |
| 202 <input type="checkbox" | 172 <input type="checkbox" |
| 203 name="rowSelect" | 173 name="rowSelect" |
| 204 value="{{result.index}}" | 174 value="{{result.index}}" |
| 205 ng-checked="isItemSelected(result.index)" | 175 ng-checked="isItemSelected(result.index)" |
| 206 ng-click="toggleItemSelected(result.index)"> | 176 ng-click="toggleItemSelected(result.index)"> |
| 207 </tr> | 177 </tr> |
| 208 </table> | 178 </table> |
| 209 </div><!-- display of current disposition type --> | 179 </div> |
| 210 </div><!-- everything: hide until data is loaded --> | |
| 211 | 180 |
| 212 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and | 181 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and |
| 213 issues list) from | 182 issues list) from |
| 214 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json | 183 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json |
| 215 ? I tried importing the | 184 ? I tried importing the |
| 216 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using | 185 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using |
| 217 that to do so, but I got Access-Control-Allow-Origin errors. | 186 that to do so, but I got Access-Control-Allow-Origin errors. |
| 218 --> | 187 --> |
| 219 | 188 |
| 220 </body> | 189 </body> |
| 221 </html> | 190 </html> |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 29603002:
Revert r11860, which was supposed to just be a whitespace change (argh) (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/