Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 296023003: Apply upgrade_enrollment Profile metrics to Mac Desktop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index aa013c16d706dde2b4e4e23c8b221e97ad446f2d..b426fe16018d9038f25b20fb86b50c5f01a5c886 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -815,6 +815,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
}
- (IBAction)openTutorialLearnMoreURL:(id)sender {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE);
// TODO(guohui): update |learnMoreUrl| once it is decided.
const GURL learnMoreUrl("https://support.google.com/chrome/?hl=en#to");
chrome::NavigateParams params(browser_->profile(), learnMoreUrl,
@@ -824,10 +826,14 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
}
- (IBAction)enableNewProfileManagementPreview:(id)sender {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_ACCEPT_NEW_PROFILE_MGMT);
profiles::EnableNewProfileManagementPreview();
}
- (IBAction)dismissTutorial:(id)sender {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_CLOSE_WELCOME_CARD);
// If the user manually dismissed the tutorial, never show it again by setting
// the number of times shown to the maximum plus 1, so that later we could
// distinguish between the dismiss case and the case when the tutorial is
@@ -838,6 +844,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
}
- (IBAction)showSendFeedbackTutorial:(id)sender {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_SEND_FEEDBACK);
tutorialMode_ = TUTORIAL_MODE_SEND_FEEDBACK;
[self initMenuContentsWithView:BUBBLE_VIEW_MODE_PROFILE_CHOOSER];
}
@@ -1012,6 +1020,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
- (NSView*)buildPreviewTutorialIfNeeded:(const AvatarMenu::Item&)item {
if (!switches::IsNewProfileManagement()) {
+ ProfileMetrics::LogProfileUpgradeEnrollment(
+ ProfileMetrics::PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO);
guohui 2014/05/22 19:43:17 i think this code will double count when the bubbl
Mike Lerman 2014/05/26 18:20:46 Done.
return [self tutorialViewWithMode:TUTORIAL_MODE_ENABLE_PREVIEW
titleMessage:IDS_PROFILES_PREVIEW_TUTORIAL_TITLE
contentMessage:IDS_PROFILES_PREVIEW_TUTORIAL_CONTENT_TEXT
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698