Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 296023003: Apply upgrade_enrollment Profile metrics to Mac Desktop. (Closed)

Created:
6 years, 7 months ago by Mike Lerman
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Apply upgrade_enrollment Profile metrics to Mac Desktop. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272909

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change tracking of tutorial views to not double count #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase and compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 3 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike Lerman
Hi Hui, Can you please review this change to ensure correctness? Shess, Owner review please? ...
6 years, 7 months ago (2014-05-20 15:43:35 UTC) #1
Scott Hess - ex-Googler
LGTM for owner. But I haven't the slightest idea whether it accomplishes what is desired ...
6 years, 7 months ago (2014-05-20 17:52:19 UTC) #2
guohui
https://codereview.chromium.org/296023003/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/296023003/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1024 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1024: ProfileMetrics::PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO); i think this code will double count when ...
6 years, 7 months ago (2014-05-22 19:43:17 UTC) #3
Mike Lerman
https://codereview.chromium.org/296023003/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/296023003/diff/20001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1024 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1024: ProfileMetrics::PROFILE_ENROLLMENT_SHOW_PREVIEW_PROMO); On 2014/05/22 19:43:17, guohui wrote: > i think ...
6 years, 7 months ago (2014-05-26 18:20:46 UTC) #4
guohui
lgtm
6 years, 7 months ago (2014-05-26 18:49:04 UTC) #5
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 7 months ago (2014-05-26 22:46:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/296023003/80001
6 years, 7 months ago (2014-05-26 22:47:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 00:41:33 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 01:54:30 UTC) #9
Message was sent while issue was closed.
Change committed as 272909

Powered by Google App Engine
This is Rietveld 408576698