Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 296023002: Get rid of HStoreNamedField::SkipWriteBarrier(). (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Get rid of HStoreNamedField::SkipWriteBarrier(). The write barrier elimination does the right thing now, so we can get rid of this hack. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -44 lines) Patch
M src/code-stubs-hydrogen.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -12 lines 0 comments Download
M src/hydrogen.cc View 7 chunks +13 lines, -21 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michael, Here's the SkipWriteBarrier() goodness we're talking about. :-) PTAL -- Benedikt
6 years, 7 months ago (2014-05-20 11:14:18 UTC) #1
mvstanton
I like adding the todo in my name ;^). lgtm.
6 years, 7 months ago (2014-05-20 11:18:37 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-20 11:25:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21384 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698