Chromium Code Reviews| Index: components/navigation_metrics/navigation_metrics.cc |
| diff --git a/components/navigation_metrics/navigation_metrics.cc b/components/navigation_metrics/navigation_metrics.cc |
| index 78df32462d84c6b20fdd45000e4f77c56bea629d..5e5290e94dfc3b6d58753153ce22eda5ab8b0932 100644 |
| --- a/components/navigation_metrics/navigation_metrics.cc |
| +++ b/components/navigation_metrics/navigation_metrics.cc |
| @@ -6,24 +6,33 @@ |
| #include "base/macros.h" |
| #include "base/metrics/histogram_macros.h" |
| +#include "components/dom_distiller/core/url_constants.h" |
| #include "url/gurl.h" |
| namespace { |
| -// This enum is used in building the histogram. So, this is append only, |
| -// any new scheme should be added at the end, before SCHEME_MAX |
| +// These values are written to logs. New enum values can be added, but existing |
| +// enums must never be renumbered or deleted and reused. Any new scheme should |
| +// be added at the end, before SCHEME_MAX. |
| enum Scheme { |
| - SCHEME_UNKNOWN, |
| - SCHEME_HTTP, |
| - SCHEME_HTTPS, |
| - SCHEME_FILE, |
| - SCHEME_FTP, |
| - SCHEME_DATA, |
| - SCHEME_JAVASCRIPT, |
| - SCHEME_ABOUT, |
| - SCHEME_CHROME, |
| - SCHEME_BLOB, |
| - SCHEME_FILESYSTEM, |
| + SCHEME_UNKNOWN = 0, |
| + SCHEME_HTTP = 1, |
| + SCHEME_HTTPS = 2, |
| + SCHEME_FILE = 3, |
| + SCHEME_FTP = 4, |
| + SCHEME_DATA = 5, |
| + SCHEME_JAVASCRIPT = 6, |
| + SCHEME_ABOUT = 7, |
| + SCHEME_CHROME = 8, |
| + SCHEME_BLOB = 9, |
| + SCHEME_FILESYSTEM = 10, |
| + SCHEME_CHROME_NATIVE = 11, |
| + SCHEME_CHROME_SEARCH = 12, |
| + SCHEME_CHROME_DISTILLER = 13, |
| + SCHEME_CHROME_DEVTOOLS = 14, |
| + SCHEME_CHROME_EXTENSION = 15, |
| + SCHEME_VIEW_SOURCE = 16, |
| + SCHEME_EXTERNALFILE = 17, |
| SCHEME_MAX, |
| }; |
| @@ -39,6 +48,13 @@ const char* const kSchemeNames[] = { |
| "chrome", |
| url::kBlobScheme, |
| url::kFileSystemScheme, |
| + "chrome-native", |
| + "chrome-search", |
| + dom_distiller::kDomDistillerScheme, |
| + "chrome-devtools", |
| + "chrome-extension", |
| + "view-source", |
| + "externalfile", |
| "max", |
|
wychen
2017/06/28 23:15:11
off-topic nit: This last item doesn't seem to be n
elawrence
2017/06/29 15:15:22
Done.
|
| }; |