Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2960153002: Move locals and closure classes from kernel/ to js_model/ (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move locals and closure classes from kernel/ to js_model/ - and rename K* to J* R=efortuna@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/fc1ec827574aa6abd9d3cc9a19af318fb052fd63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -425 lines) Patch
A + pkg/compiler/lib/src/js_model/closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 2 chunks +2 lines, -1 line 0 comments Download
A pkg/compiler/lib/src/js_model/locals.dart View 1 chunk +278 lines, -0 lines 0 comments Download
D pkg/compiler/lib/src/kernel/closure.dart View 1 chunk +0 lines, -154 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 3 chunks +2 lines, -268 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-06-28 09:22:46 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-28 16:05:23 UTC) #3
Emily Fortuna
lgtm
3 years, 5 months ago (2017-06-28 18:06:44 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-06-29 09:08:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc1ec827574aa6abd9d3cc9a19af318fb052fd63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698