Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 2960143002: MD Bookmarks: Remove '/?id=1' from URL when displaying Bookmarks Bar (Closed)
Patch Set: Review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/util.js ('k') | chrome/browser/ui/webui/bookmarks_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index d9880d5b3f0f1e459155fc1b5d5e97753deb2bcd..f04527b24c0bce71621ee6ce06da8cb4bd94903c 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -169,17 +169,10 @@ std::string GenerateContentSettingsExceptionsSubPage(ContentSettingsType type) {
void ShowBookmarkManager(Browser* browser) {
base::RecordAction(UserMetricsAction("ShowBookmarkManager"));
- if (MdBookmarksUI::IsEnabled()) {
- const bookmarks::BookmarkNode* bookmark_bar_node =
- BookmarkModelFactory::GetForBrowserContext(browser->profile())
- ->bookmark_bar_node();
- OpenBookmarkManagerForNode(browser, bookmark_bar_node->id());
- return;
- }
-
- ShowSingletonTabOverwritingNTP(
- browser,
+ NavigateParams params(
GetSingletonTabNavigateParams(browser, GURL(kChromeUIBookmarksURL)));
+ params.path_behavior = NavigateParams::IGNORE_AND_STAY_PUT;
+ ShowSingletonTabOverwritingNTP(browser, params);
}
void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id) {
« no previous file with comments | « chrome/browser/resources/md_bookmarks/util.js ('k') | chrome/browser/ui/webui/bookmarks_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698