MD Bookmarks: Remove '/?id=1' from URL when displaying Bookmarks Bar

chrome/browser/ui/chrome_pages.cc

Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index d9880d5b3f0f1e459155fc1b5d5e97753deb2bcd..e496ac1d2a6014811f4ccb4b758a55afd2e96891 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -169,17 +169,10 @@ std::string GenerateContentSettingsExceptionsSubPage(ContentSettingsType type) {
 
 void ShowBookmarkManager(Browser* browser) {
   base::RecordAction(UserMetricsAction("ShowBookmarkManager"));
-  if (MdBookmarksUI::IsEnabled()) {
-    const bookmarks::BookmarkNode* bookmark_bar_node =
-        BookmarkModelFactory::GetForBrowserContext(browser->profile())
-            ->bookmark_bar_node();
-    OpenBookmarkManagerForNode(browser, bookmark_bar_node->id());
-    return;
-  }
-
-  ShowSingletonTabOverwritingNTP(
-      browser,
+  NavigateParams params(
       GetSingletonTabNavigateParams(browser, GURL(kChromeUIBookmarksURL)));
+  params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;

[calamity, 2017/07/05 04:04:39]

This would be wayyy better as IGNORE_AND_STAY_PUT actually. Possibly ditto for
History now that I think about it..

[tsergeant, 2017/07/05 07:37:36]

Done for Bookmarks.

I was really on the fence about this and flipped back and forward while writing
the patch, but I'm happy to go with it.

Less sure about History -- because it doesn't real-time update,
IGNORE_AND_NAVIGATE ensures that you see fresh data.

[calamity, 2017/07/06 04:16:29]

I just find it weird when I want to go back to the page, and it takes me there,
but it also destroys my state.

[tsergeant, 2017/07/06 04:51:05]

I understand, but there's precedent for the current behavior -- settings,
extensions, etc all work like this. I'll file a bug and we can discuss there.

+  ShowSingletonTabOverwritingNTP(browser, params);
 }
 
 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id) {