Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: pkg/analysis_server/lib/src/domain_analytics.dart

Issue 2960073002: Generate constants in server as we do in plugin (Closed)
Patch Set: improve names Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_analytics.dart
diff --git a/pkg/analysis_server/lib/src/domain_analytics.dart b/pkg/analysis_server/lib/src/domain_analytics.dart
index b2b6706c6d1363889d00dfe2f3aa87671c12f570..f6ad37e675a1cacb879dbc3fab9991728f3f53e7 100644
--- a/pkg/analysis_server/lib/src/domain_analytics.dart
+++ b/pkg/analysis_server/lib/src/domain_analytics.dart
@@ -5,9 +5,9 @@
import 'dart:core';
import 'package:analysis_server/protocol/protocol.dart';
+import 'package:analysis_server/protocol/protocol_constants.dart';
import 'package:analysis_server/protocol/protocol_generated.dart';
import 'package:analysis_server/src/analysis_server.dart';
-import 'package:analysis_server/src/constants.dart';
/// Instances of the class [AnalyticsDomainHandler] implement a [RequestHandler]
/// that handles requests in the `analytics` domain.
@@ -35,13 +35,13 @@ class AnalyticsDomainHandler implements RequestHandler {
@override
Response handleRequest(Request request) {
String requestName = request.method;
- if (requestName == ANALYTICS_IS_ENABLED) {
+ if (requestName == ANALYTICS_REQUEST_IS_ENABLED) {
return handleIsEnabled(request);
- } else if (requestName == ANALYTICS_ENABLE) {
+ } else if (requestName == ANALYTICS_REQUEST_ENABLE) {
return handleEnable(request);
- } else if (requestName == ANALYTICS_SEND_EVENT) {
+ } else if (requestName == ANALYTICS_REQUEST_SEND_EVENT) {
return handleSendEvent(request);
- } else if (requestName == ANALYTICS_SEND_TIMING) {
+ } else if (requestName == ANALYTICS_REQUEST_SEND_TIMING) {
return handleSendTiming(request);
}
« no previous file with comments | « pkg/analysis_server/lib/src/domain_analysis.dart ('k') | pkg/analysis_server/lib/src/domain_completion.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698