Fix the documentation and add Device.deviceName in sessions API.

Fix the documentation and add Device.deviceName in sessions API.

Updated the description of Device.info. Added Device.deviceName to be the same as Device.info.

R=kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272780

[wjywbs, 2014-05-23 21:10:33]

PTAL, thanks.

https://codereview.chromium.org/296003016/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/sessions.json (right):

https://codereview.chromium.org/296003016/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/sessions.json:36: "info": {"type": "string",
"description": "The name of the foreign device."},
Do we need to change "info" to "deviceName" as well?

[not at google - send to devlin, 2014-05-23 21:25:35]

thanks for this

https://codereview.chromium.org/296003016/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/sessions.json (right):

https://codereview.chromium.org/296003016/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/sessions.json:36: "info": {"type": "string",
"description": "The name of the foreign device."},
On 2014/05/23 21:10:34, wjywbs wrote:
> Do we need to change "info" to "deviceName" as well?

yes we might as well make this CL pull its weight: I'm thinking that we "nodoc"
this property and add a deviceName, then set both to the same value (and update
test(s)).

[wjywbs, 2014-05-23 21:54:33]

PTAL. Thanks.

https://codereview.chromium.org/296003016/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right):

https://codereview.chromium.org/296003016/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/sessions/sessions_apitest.cc:348:
"sessions.html")) << message_;
There's no test calling and checking the getDevices() function in this html
file.

[not at google - send to devlin, 2014-05-23 21:59:00]

lgtm

https://codereview.chromium.org/296003016/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right):

https://codereview.chromium.org/296003016/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/sessions/sessions_apitest.cc:348:
"sessions.html")) << message_;
On 2014/05/23 21:54:34, wjywbs wrote:
> There's no test calling and checking the getDevices() function in this html
> file.

ok.

https://codereview.chromium.org/296003016/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/sessions.json (right):

https://codereview.chromium.org/296003016/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/sessions.json:36: "info": {"type": "string"},
put "nodoc": true on this

[wjywbs, 2014-05-23 22:13:33]

I put the nodoc tag. PTAL, thanks.

[not at google - send to devlin, 2014-05-23 22:15:06]

lgtm

[wjywbs, 2014-05-23 22:15:20]

The CQ bit was checked by wjywbs@gmail.com

[commit-bot: I haz the power, 2014-05-23 22:18:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjywbs@gmail.com/296003016/40001

[commit-bot: I haz the power, 2014-05-24 01:56:45]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-24 04:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-24 04:27:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[wjywbs, 2014-05-24 15:22:06]

The CQ bit was checked by wjywbs@gmail.com

[commit-bot: I haz the power, 2014-05-24 15:22:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wjywbs@gmail.com/296003016/40001

[commit-bot: I haz the power, 2014-05-24 23:20:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-26 04:11:21]

Change committed as 272780