Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: trunk/src/chrome/browser/translate/translate_tab_helper.cc

Issue 296003014: Revert 272217 "LanguageState should be owned by TranslateManager" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/translate/translate_tab_helper.cc
===================================================================
--- trunk/src/chrome/browser/translate/translate_tab_helper.cc (revision 272260)
+++ trunk/src/chrome/browser/translate/translate_tab_helper.cc (working copy)
@@ -23,7 +23,6 @@
#include "chrome/browser/ui/translate/translate_bubble_factory.h"
#include "chrome/common/pref_names.h"
#include "components/translate/content/common/translate_messages.h"
-#include "components/translate/core/browser/language_state.h"
#include "components/translate/core/browser/page_translated_details.h"
#include "components/translate/core/browser/translate_accept_languages.h"
#include "components/translate/core/browser/translate_download_manager.h"
@@ -81,7 +80,7 @@
}
LanguageState& TranslateTabHelper::GetLanguageState() {
- return translate_manager_->GetLanguageState();
+ return translate_driver_.GetLanguageState();
}
// static
@@ -268,7 +267,7 @@
}
if (!load_details.is_main_frame &&
- GetLanguageState().translation_declined()) {
+ translate_driver_.GetLanguageState().translation_declined()) {
// Some sites (such as Google map) may trigger sub-frame navigations
// when the user interacts with the page. We don't want to show a new
// infobar if the user already dismissed one in that case.
@@ -281,7 +280,7 @@
return;
}
- if (!GetLanguageState().page_needs_translation())
+ if (!translate_driver_.GetLanguageState().page_needs_translation())
return;
// Note that we delay it as the ordering of the processing of this callback
@@ -292,7 +291,7 @@
FROM_HERE,
base::Bind(&TranslateTabHelper::InitiateTranslation,
weak_pointer_factory_.GetWeakPtr(),
- GetLanguageState().original_language(),
+ translate_driver_.GetLanguageState().original_language(),
0));
}
@@ -300,11 +299,7 @@
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
// Let the LanguageState clear its state.
- const bool reload =
- details.entry->GetTransitionType() == content::PAGE_TRANSITION_RELOAD ||
- details.type == content::NAVIGATION_TYPE_SAME_PAGE;
- GetLanguageState().DidNavigate(
- details.is_in_page, details.is_main_frame, reload);
+ translate_driver_.DidNavigate(details);
}
void TranslateTabHelper::WebContentsDestroyed() {
@@ -450,7 +445,7 @@
void TranslateTabHelper::InitiateTranslation(const std::string& page_lang,
int attempt) {
- if (GetLanguageState().translation_pending())
+ if (translate_driver_.GetLanguageState().translation_pending())
return;
// During a reload we need web content to be available before the
@@ -476,7 +471,7 @@
void TranslateTabHelper::OnLanguageDetermined(
const LanguageDetectionDetails& details,
bool page_needs_translation) {
- GetLanguageState().LanguageDetermined(
+ translate_driver_.GetLanguageState().LanguageDetermined(
details.adopted_language, page_needs_translation);
if (web_contents())
« no previous file with comments | « trunk/src/chrome/browser/translate/translate_tab_helper.h ('k') | trunk/src/chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698