Issue 296003013: - Reduce the number of Isolate::Current() calls.

Issue 296003013: - Reduce the number of Isolate::Current() calls. (Closed)

Created:
6 years, 7 months ago by Ivan Posva

Modified:
6 years, 7 months ago

Reviewers:
Cutch, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Reduce the number of Isolate::Current() calls. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36564

Patch Set 2 : #

Total comments: 3

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2006 lines, -1472 lines)			Patch
M	runtime/vm/allocation.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/allocation.cc	View		2 chunks	+12 lines, -2 lines	0 comments	Download
M	runtime/vm/code_patcher.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/growable_array.h	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	13 chunks	+33 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	111 chunks	+403 lines, -302 lines	3 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	109 chunks	+351 lines, -260 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	118 chunks	+417 lines, -318 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	111 chunks	+321 lines, -220 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	118 chunks	+398 lines, -298 lines	0 comments	Download
M	runtime/vm/locations.h	View	1	3 chunks	+16 lines, -6 lines	0 comments	Download
M	runtime/vm/locations.cc	View	1	4 chunks	+15 lines, -18 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	runtime/vm/pages.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://codereview.chromium.org/296003013/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc (right): https://codereview.chromium.org/296003013/diff/1/runtime/vm/flow_graph_allocator.cc#newcode138 runtime/vm/flow_graph_allocator.cc:138: current->InitializeLocationSummary(Isolate::Current(), true); // Optimizing. 80 char limit exceeded https://codereview.chromium.org/296003013/diff/1/runtime/vm/flow_graph_compiler.cc ...

6 years, 7 months ago (2014-05-22 17:25:08 UTC) #2

Ivan Posva

https://codereview.chromium.org/296003013/diff/20001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/296003013/diff/20001/runtime/vm/intermediate_language_arm.cc#newcode41 runtime/vm/intermediate_language_arm.cc:41: bool opt) const { Fixing the formatting of this ...

6 years, 7 months ago (2014-05-23 09:19:29 UTC) #3

Cutch

lgtm https://codereview.chromium.org/296003013/diff/20001/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/296003013/diff/20001/runtime/vm/intermediate_language_arm.cc#newcode131 runtime/vm/intermediate_language_arm.cc:131: bool opt) const { wrong indent on bool ...

6 years, 7 months ago (2014-05-23 09:28:36 UTC) #4

Ivan Posva

6 years, 7 months ago (2014-05-23 12:07:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r36564 (presubmit successful).

Expand Messages | Collapse Messages