Issue 296003008: Revert of upload SKP renderings that did not match expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296003008: Revert of upload SKP renderings that did not match expectations (Closed)

Created:
6 years, 7 months ago by epoger

Modified:
6 years, 7 months ago

Reviewers:
borenet, rmistry

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/buildbot.git@master

Visibility:
Public.

Revert of upload SKP renderings that did not match expectations (https://codereview.chromium.org/295753002/) Reason for revert: http://skbug.com/2582 ('PreRender and UploadRenderedSKPs steps failing on some builders after my buildbot change') Original issue's description: > upload SKP renderings that did not match expectations > > BUG=skia:1942 > > Committed: https://skia.googlesource.com/buildbot/+/45fa087c24e3f6bab61bd951b4cb6280c0f4f2c6 TBR=borenet@google.com,rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1942 Committed: https://skia.googlesource.com/buildbot/+/4fe3ede058b4522336054bdecc388fd682a4bc2c

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -232 lines)			Patch
M	slave/skia_slave_scripts/build_step.py	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py	View	2 chunks	+12 lines, -15 lines	0 comments	Download
M	slave/skia_slave_scripts/flavor_utils/default_build_step_utils.py	View	6 chunks	+9 lines, -38 lines	0 comments	Download
M	slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	slave/skia_slave_scripts/playback_dirs.py	View	4 chunks	+11 lines, -41 lines	0 comments	Download
M	slave/skia_slave_scripts/postrender.py	View	1 chunk	+3 lines, -16 lines	0 comments	Download
M	slave/skia_slave_scripts/prerender.py	View	3 chunks	+4 lines, -27 lines	0 comments	Download
M	slave/skia_slave_scripts/render_skps.py	View	1 chunk	+29 lines, -58 lines	0 comments	Download
M	slave/skia_slave_scripts/run_gm.py	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	slave/skia_slave_scripts/upload_rendered_skps.py	View	2 chunks	+9 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

epoger

Created Revert of upload SKP renderings that did not match expectations

6 years, 7 months ago (2014-05-21 14:11:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/296003008/1

6 years, 7 months ago (2014-05-21 14:11:51 UTC) #2

commit-bot: I haz the power

6 years, 7 months ago (2014-05-21 14:12:01 UTC) #3

Message was sent while issue was closed.

Change committed as 4fe3ede058b4522336054bdecc388fd682a4bc2c