tools/binary_size/run_binary_size_analysis.py - Issue 296003007: Added PRESUBMIT.py for binary_size tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/run_binary_size_analysis.py

Issue 296003007: Added PRESUBMIT.py for binary_size tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@andrew_binary_size

Patch Set: Taking advantage of the unittest system. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/binary_size/run_binary_size_analysis.py

diff --git a/tools/binary_size/run_binary_size_analysis.py b/tools/binary_size/run_binary_size_analysis.py

index 7647a22dcb69b351b429f0e6e35911dd39e1b8be..adde55c6aae73a0198f0bc230d9ae03c09b5ec8f 100755

--- a/tools/binary_size/run_binary_size_analysis.py

+++ b/tools/binary_size/run_binary_size_analysis.py

@@ -36,7 +36,7 @@ elf_symbolizer_path = os.path.abspath(os.path.join(

'android',

'pylib'))

sys.path.append(elf_symbolizer_path)

-import symbols.elf_symbolizer as elf_symbolizer

+import symbols.elf_symbolizer as elf_symbolizer # pylint: disable=F0401

Primiano Tucci (use gerrit) 2014/05/22 19:02:34 Nit: add extra space here before the "#" (PEP-8: I

# TODO(andrewhayden): Only used for legacy reports. Delete.

« tools/binary_size/explain_binary_size_delta_unittest.py ('K') | « tools/binary_size/explain_binary_size_delta_unittest.py ('k') | no next file » | no next file with comments »