Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: content/browser/loader/resource_request_info_impl.h

Issue 2960023002: Remove SupportsUserData from ResourceRequestBodyImpl. (Closed)
Patch Set: Switch to BlobHandles*, fix two comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_request_info_impl.h
diff --git a/content/browser/loader/resource_request_info_impl.h b/content/browser/loader/resource_request_info_impl.h
index d9dac75d25610e48459a7dfab25e535e2a1e5eaf..18a37243690219bc5f994b4ce9e11ca95dfc2602 100644
--- a/content/browser/loader/resource_request_info_impl.h
+++ b/content/browser/loader/resource_request_info_impl.h
@@ -14,6 +14,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/supports_user_data.h"
+#include "content/browser/blob_storage/chrome_blob_storage_context.h"
#include "content/browser/loader/resource_requester_info.h"
#include "content/common/resource_request_body_impl.h"
#include "content/common/url_loader.mojom.h"
@@ -200,6 +201,8 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
on_transfer_ = on_transfer;
}
+ void SetBlobHandles(BlobHandles blob_handles);
+
private:
FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest,
DeletedFilterDetached);
@@ -239,6 +242,9 @@ class ResourceRequestInfoImpl : public ResourceRequestInfo,
bool initiated_in_secure_context_;
std::unique_ptr<NavigationUIData> navigation_ui_data_;
+ // Keeps blobs alive for the duration of the request.
kinuko 2017/06/28 01:43:28 Could we also briefly note that it's for uploading
mmenke 2017/06/28 17:31:37 Done.
+ BlobHandles blob_handles_;
+
// This callback is set by MojoAsyncResourceHandler to update its mojo binding
// and remote endpoint. This callback will be removed once PlzNavigate is
// shipped.
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/resource_request_info_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698