Remove SupportsUserData from ResourceRequestBodyImpl.

content/browser/blob_storage/chrome_blob_storage_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FILEAPI_CHROME_BLOB_STORAGE_CONTEXT_H_
 #define CONTENT_BROWSER_FILEAPI_CHROME_BLOB_STORAGE_CONTEXT_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
+#include <vector>
 
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner_helpers.h"
 #include "content/common/content_export.h"
+#include "storage/browser/blob/blob_data_handle.h"
 
 namespace base {
 class FilePath;
 class TaskRunner;
 class Time;
 }
 
 namespace storage {
 class BlobStorageContext;
 }
@@ skipping 55 matching lines @@
   static void Destruct(const ChromeBlobStorageContext* context) {
     context->DeleteOnCorrectThread();
   }
 };
 
 // Returns the BlobStorageContext associated with the
 // ChromeBlobStorageContext instance passed in.
 storage::BlobStorageContext* GetBlobStorageContext(
     ChromeBlobStorageContext* blob_storage_context);
 
-// Attaches blob data handles to the ResourceRequestBodyImpl body passed in.
-// This is used for POST and PUT requests.
-bool AttachRequestBodyBlobDataHandles(ResourceRequestBodyImpl* body,
-                                      ResourceContext* resource_context);
+using BlobHandles = std::vector<std::unique_ptr<storage::BlobDataHandle>>;
+
+// returns a vector of BlobDataHandles, that ensure the data isn't cleaned up
+// until they're destroyed. Returns nullptr on failure, and an empty vector when
+// there are no blobs. This is used for POST and PUT requests.
+std::unique_ptr<BlobHandles> GetBodyBlobDataHandles(

[dmurph, 2017/06/27 21:29:07]

Can you have this just return the vector? You can just std::move it out.

[mmenke, 2017/06/27 21:32:22]

We need a way to fail.  The only reason I used a unique_ptr was so that we could
return nullptr.  I could return a bool and take a BlobHandles* as an argument. 
Open to other ideas.

[dmurph, 2017/06/27 21:35:53]

What about providing the 'out' vector in an argument, and returning a bool?

[mmenke, 2017/06/27 21:48:44]

Works for me, done.

+    ResourceRequestBodyImpl* body,
+    ResourceContext* resource_context);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FILEAPI_CHROME_BLOB_STORAGE_CONTEXT_H_