Oilpan: Use transition types for HTMLDivElement.

Oilpan: Use transition types for HTMLDivElement.

BUG=357163
R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174574

[haraken, 2014-05-21 13:36:27]

LGTM

https://codereview.chromium.org/295993007/diff/1/Source/core/html/forms/BaseC...
File Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/295993007/diff/1/Source/core/html/forms/BaseC...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:64:
RefPtrWillBeMember<HTMLDivElement> valueContainer =
HTMLDivElement::create(element().document());

This should be RefPtrWillBeRawPtr

[zerny-chromium, 2014-05-21 13:42:32]

Thanks for the review.

https://codereview.chromium.org/295993007/diff/1/Source/core/html/forms/BaseC...
File Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/295993007/diff/1/Source/core/html/forms/BaseC...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:64:
RefPtrWillBeMember<HTMLDivElement> valueContainer =
HTMLDivElement::create(element().document());
On 2014/05/21 13:36:27, haraken wrote:
> 
> This should be RefPtrWillBeRawPtr

Done. (darn that M-/)

[zerny-chromium, 2014-05-21 13:42:39]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-05-21 17:52:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zerny@chromium.org/295993007/20001

[commit-bot: I haz the power, 2014-05-22 02:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 02:48:31]

Failed to apply patch for Source/core/html/HTMLDetailsElement.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/html/HTMLDetailsElement.cpp
  Hunk #1 FAILED at 89.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/html/HTMLDetailsElement.cpp.rej

Patch:       Source/core/html/HTMLDetailsElement.cpp
Index: Source/core/html/HTMLDetailsElement.cpp
diff --git a/Source/core/html/HTMLDetailsElement.cpp
b/Source/core/html/HTMLDetailsElement.cpp
index
729b08c75b2edd8d5cd1752fd08424be06a61f90..e6847567dfbf0cc131222396f030182c03a98b57
100644
--- a/Source/core/html/HTMLDetailsElement.cpp
+++ b/Source/core/html/HTMLDetailsElement.cpp
@@ -89,7 +89,7 @@ void HTMLDetailsElement::didAddUserAgentShadowRoot(ShadowRoot&
root)
     summary->appendChild(defaultSummary);
     root.appendChild(summary.release());
 
-    RefPtr<HTMLDivElement> content = HTMLDivElement::create(document());
+    RefPtrWillBeRawPtr<HTMLDivElement> content =
HTMLDivElement::create(document());
     content->setIdAttribute(ShadowElementNames::detailsContent());
     content->appendChild(HTMLContentElement::create(document()));
     content->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);

[zerny-chromium, 2014-05-22 07:42:39]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-05-22 07:43:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zerny@chromium.org/295993007/30001

[commit-bot: I haz the power, 2014-05-22 17:26:46]

Change committed as 174574