Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 295993006: Deprecate the overflowchanged event (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
Reviewers:
ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M LayoutTests/fast/events/change-overflow-on-overflow-change-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/overflow-events-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/overflow-events-writing-mode-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/overflow-viewport-renderer-deleted-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/events/overflowchanged-event-raf-timing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/overflow/layout-overflow-not-affected-by-visual-overflow-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL.
6 years, 7 months ago (2014-05-21 20:34:52 UTC) #1
ojan
lgtm FYI, in the future, there's no need for BUG=none. You can just leave the ...
6 years, 7 months ago (2014-05-21 23:20:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/295993006/40001
6 years, 7 months ago (2014-05-21 23:22:31 UTC) #3
philipj_slow
On 2014/05/21 23:20:34, ojan wrote: > lgtm > > FYI, in the future, there's no ...
6 years, 7 months ago (2014-05-22 07:08:17 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 07:24:38 UTC) #5
Message was sent while issue was closed.
Change committed as 174529

Powered by Google App Engine
This is Rietveld 408576698