Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Release Blockers | 1 # Release Blockers |
| 2 | 2 |
| 3 [TOC] | 3 [TOC] |
| 4 | 4 |
| 5 ## tl;dr | 5 ## tl;dr |
| 6 | 6 |
| 7 * Only mark bugs as blockers if the product **must not** be shipped with the | 7 * Only mark bugs as blockers if the product **must not** be shipped with the |
| 8 bug present. | 8 bug present. |
| 9 * **Everyone** on the team can add or remove blocking labels. | 9 * **Everyone** on the team can add or remove blocking labels. |
| 10 * Evaluate bugs as potential blockers based on their **severity** and | 10 * Evaluate bugs as potential blockers based on their **severity** and |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 80 downloading files, etc. | 80 downloading files, etc. |
| 81 * **All (75% - 100%)**: The bug affects core product functionality, e.g. | 81 * **All (75% - 100%)**: The bug affects core product functionality, e.g. |
| 82 scrolling a page. | 82 scrolling a page. |
| 83 | 83 |
| 84 Note that prevalence should be evaluated based on the population of users they | 84 Note that prevalence should be evaluated based on the population of users they |
| 85 affect - e.g. a bug affecting all Android users (but not Windows users) | 85 affect - e.g. a bug affecting all Android users (but not Windows users) |
| 86 would still be considered to affect all users, and a bug affecting all | 86 would still be considered to affect all users, and a bug affecting all |
| 87 Enterprise Windows users (but not all consumer Windows users) could also be | 87 Enterprise Windows users (but not all consumer Windows users) could also be |
| 88 considered to affect all users. | 88 considered to affect all users. |
| 89 | 89 |
| 90 ### Known unknowns | |
|
amineer
2017/07/06 21:57:16
"Addressing Uncertainty"
| |
| 91 | |
| 92 Known unknowns are defined as the assessable likelihood that the actual true | |
| 93 severity and prevalence may be higher than initially observed. Examples: | |
| 94 * **High** - A recently introduced race condition causing tabs to never load | |
|
amineer
2017/07/06 21:57:16
I don't know that adding dimensions here (e.g. bre
| |
| 95 (without crashing, and thus without generating a report for our metrics). | |
| 96 There are few user complaints so far, but there's reason to believe it might | |
| 97 show up more frequently with Arabic language builds, where we tend to | |
| 98 receive feedback more slowly due to the language barrier. | |
| 99 * **Medium** - A recently introduced CSS bug causing slightly misaligned | |
| 100 layout. But there's a slim possibility that on a different site we haven't | |
| 101 tested yet, the content might be misaligned all the way off the screen. | |
| 102 * **None** - A longstanding null pointer crash with a simple local repro and | |
| 103 trustworthy prevalence metrics from Stable channel users. | |
| 104 * **N/A** - The person adding the releaseblock label doesn't have enough | |
| 105 information to assess this. | |
| 106 | |
| 90 ### Customization | 107 ### Customization |
| 91 | 108 |
| 92 The definitions provided above are examples; teams are encouraged to customize | 109 The definitions provided above are examples; teams are encouraged to customize |
| 93 where it makes sense, e.g. the web platform team may consider developer impact | 110 where it makes sense, e.g. the web platform team may consider developer impact |
| 94 for severity and feature usage for prevalence. | 111 for severity and feature usage for prevalence. |
| 95 | 112 |
| 96 ## Blocker Management | 113 ## Blocker Management |
| 97 | 114 |
| 98 **Everyone should feel free to add, modify, or remove release blocking labels | 115 **Everyone should feel free to add, modify, or remove release blocking labels |
| 99 where appropriate, so long as you follow the guidelines below.** If a TPM or | 116 where appropriate, so long as you follow the guidelines below.** If a TPM or |
| (...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 134 | 151 |
| 135 ### Regressions | 152 ### Regressions |
| 136 | 153 |
| 137 Regressions should follow the same guidelines as listed above; an issue should | 154 Regressions should follow the same guidelines as listed above; an issue should |
| 138 not be tagged as a release blocker simply because it is a regression. While | 155 not be tagged as a release blocker simply because it is a regression. While |
| 139 we'd like to prevent regressions in general, there is a large backlog of bugs we | 156 we'd like to prevent regressions in general, there is a large backlog of bugs we |
| 140 need to address, and we should focus on the most important. To ensure we | 157 need to address, and we should focus on the most important. To ensure we |
| 141 maintain a high bar for product quality, we should track the number of | 158 maintain a high bar for product quality, we should track the number of |
| 142 introduced versus escaped regressions, and follow up if the number starts to | 159 introduced versus escaped regressions, and follow up if the number starts to |
| 143 rise. | 160 rise. |
| 161 | |
| 162 In practice, it is still expected that the majority of release blockers filed | |
| 163 will be recent regressions, because on average they have higher severity, | |
| 164 prevalence and unknowns than longstanding bugs. (A rule of thumb is that the | |
| 165 longer a bug has been present on stable channel without intense pressure to fix, | |
| 166 the greater the odds that severity/prevalence/unknowns are actually low.) | |
|
amineer
2017/07/06 21:57:16
s/unknowns/uncertainty
| |
| OLD | NEW |