chrome/android/java/res/layout/tabular_context_menu_row.xml - Issue 2959853002: Adding smarter resizing logic for the context menu on orientation changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/tabular_context_menu_row.xml

Issue 2959853002: Adding smarter resizing logic for the context menu on orientation changes (Closed)

Patch Set: comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"	5 <org.chromium.chrome.browser.widget.BoundedLinearLayout

	6 xmlns:android="http://schemas.android.com/apk/res/android"

	7 xmlns:chrome="http://schemas.android.com/apk/res-auto"

6 xmlns:tools="http://schemas.android.com/tools"	8 xmlns:tools="http://schemas.android.com/tools"

7 android:orientation="horizontal"	9 android:orientation="horizontal"

8 android:layout_width="match_parent"	10 android:layout_width="match_parent"

9 android:layout_height="wrap_content"	11 android:layout_height="wrap_content"

10 android:paddingStart="15dp"	12 android:paddingStart="15dp"

11 android:minHeight="40dp"	13 android:minHeight="40dp"

	14 chrome:maxHeight="40dp"

12 tools:ignore="UseCompoundDrawables">	15 tools:ignore="UseCompoundDrawables">

13 <ImageView	16 <ImageView

14 android:id="@+id/context_menu_icon"	17 android:id="@+id/context_menu_icon"

15 android:layout_width="20dp"	18 android:layout_width="20dp"

16 android:layout_height="match_parent"	19 android:layout_height="match_parent"

17 android:paddingTop="10dp"	20 android:paddingTop="10dp"

18 android:paddingBottom="10dp"	21 android:paddingBottom="10dp"

19 android:scaleType="centerInside"	22 android:scaleType="centerInside"

20 android:contentDescription="@null" />	23 android:contentDescription="@null" />

21 <TextView	24 <TextView

(...skipping 13 matching lines...) Expand all Loading...
35 android:paddingBottom="8dp"	38 android:paddingBottom="8dp"

36 android:paddingStart="12dp"	39 android:paddingStart="12dp"

37 android:paddingEnd="15dp"	40 android:paddingEnd="15dp"

38 android:scaleType="centerInside"	41 android:scaleType="centerInside"

39 android:contentDescription="@null"	42 android:contentDescription="@null"

40 android:visibility="gone"/>	43 android:visibility="gone"/>

41 <Space	44 <Space

42 android:id="@+id/context_menu_right_padding"	45 android:id="@+id/context_menu_right_padding"

43 android:layout_width="15dp"	46 android:layout_width="15dp"

44 android:layout_height="wrap_content"/>	47 android:layout_height="wrap_content"/>

45 </LinearLayout>	48 </org.chromium.chrome.browser.widget.BoundedLinearLayout>

OLD	NEW

« no previous file with comments | « chrome/android/java/res/layout/tabular_context_menu_page.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »