Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 295983011: Remove dcheck for unkonwn signin source (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index fceb3e6035a798f03f14e8afc46a01771eb6f361..19948526e27236d8cb34f18d2300fbc132415a92 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -754,8 +754,8 @@ void OneClickSigninHelper::LogHistogramValue(
// This switch statement needs to be updated when the enum Source changes.
COMPILE_ASSERT(signin::SOURCE_UNKNOWN == 12,
kSourceEnumHasChangedButNotThisSwitchStatement);
- NOTREACHED();
- return;
+ UMA_HISTOGRAM_ENUMERATION("Signin.UnknownActions", action,
+ one_click_signin::HISTOGRAM_MAX);
}
UMA_HISTOGRAM_ENUMERATION("Signin.AllAccessPointActions", action,
one_click_signin::HISTOGRAM_MAX);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698