Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 295983011: Remove dcheck for unkonwn signin source (Closed)

Created:
6 years, 7 months ago by guohui
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove dcheck for unkonwn signin source BUG=376924 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
guohui
Hey, Could you please review the CL? Thanks, Hui
6 years, 7 months ago (2014-05-23 20:14:06 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 7 months ago (2014-05-23 20:37:54 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 7 months ago (2014-05-23 20:49:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/295983011/1
6 years, 7 months ago (2014-05-23 20:50:58 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:39:35 UTC) #5
Message was sent while issue was closed. 
Change committed as 272720

Powered by Google App Engine
This is Rietveld 408576698