Issue 295983008: test_runner: Migrate MockConstraint to our Chromium C++ style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295983008: test_runner: Migrate MockConstraint to our Chromium C++ style. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, darin2, jochen (gone - plz use gerrit), jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

test_runner: Migrate MockConstraints to our Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Fix variables names to use unix_hacker style. 3) Fix method name to use CamelCase style. 4) Rename file name to mock_constraints. BUG=331299 TEST=content_unittests, content_shell. No functional changes R=dpranke@chromium.org TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272238

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -91 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/MockConstraints.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	content/shell/renderer/test_runner/MockConstraints.cpp	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebUserMediaClientMock.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/shell/renderer/test_runner/mock_constraints.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
A	content/shell/renderer/test_runner/mock_constraints.cc	View	1 chunk	+62 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/295983008/60001

6 years, 7 months ago (2014-05-22 17:03:21 UTC) #3

tfarina

6 years, 7 months ago (2014-05-22 18:15:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r272238 (presubmit successful).