Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2959823002: Add type inference for super property gets. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for super property gets. I implemented the correct logic for both SuperPropertyGet and DirectPropertyGet, since there are TODO comments in the code indicating that the former will be replaced by the latter when possible. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9f078625d4ffc803cf85013bb8d33b9d1c661205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -41 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 6 chunks +16 lines, -27 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +8 lines, -10 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get.dart.direct.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get.dart.outline.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_function_typed.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_function_typed.dart.direct.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_function_typed.dart.outline.expect View 1 chunk +17 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_function_typed.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_implicit_call.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_implicit_call.dart.direct.expect View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_implicit_call.dart.outline.expect View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_invoke_implicit_call.dart.strong.expect View 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_tearoff.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_tearoff.dart.direct.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_tearoff.dart.outline.expect View 1 chunk +18 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/super_property_get_tearoff.dart.strong.expect View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-26 19:50:13 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 20:20:25 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 20:40:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9f078625d4ffc803cf85013bb8d33b9d1c661205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698