PDF: Selection Invalidation should compensate for rounding errors.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 3273 matching lines @@
         // Mark the rectangles by setting them to empty.
         new_selection = old_selection = pp::Rect();
         break;
       }
     }
   }
 
   bool selection_changed = false;
   for (const auto& old_selection : old_selections_) {
     if (!old_selection.IsEmpty()) {
-      engine_->client_->Invalidate(old_selection);
+      Invalidate(old_selection);
       selection_changed = true;
     }
   }
   for (const auto& new_selection : new_selections) {
     if (!new_selection.IsEmpty()) {
-      engine_->client_->Invalidate(new_selection);
+      Invalidate(new_selection);
       selection_changed = true;
     }
   }
   if (selection_changed)
     engine_->OnSelectionChanged();
 }
 
 std::vector<pp::Rect>
 PDFiumEngine::SelectionChangeInvalidator::GetVisibleSelections() const {
   std::vector<pp::Rect> rects;
   pp::Point visible_point = engine_->GetVisibleRect().point();
   for (auto& range : engine_->selection_) {
     // Exclude selections on pages that's not currently visible.
     if (!engine_->IsPageVisible(range.page_index()))
       continue;
 
     std::vector<pp::Rect> selection_rects = range.GetScreenRects(
         visible_point, engine_->current_zoom_, engine_->current_rotation_);
     rects.insert(rects.end(), selection_rects.begin(), selection_rects.end());
   }
   return rects;
 }
 
+void PDFiumEngine::SelectionChangeInvalidator::Invalidate(
+    const pp::Rect& selection) {
+  pp::Rect expanded_selection = selection;
+  expanded_selection.Inset(-1, -1);
+  engine_->client_->Invalidate(expanded_selection);
+}
+
 PDFiumEngine::MouseDownState::MouseDownState(
     const PDFiumPage::Area& area,
     const PDFiumPage::LinkTarget& target)
     : area_(area), target_(target) {}
 
 PDFiumEngine::MouseDownState::~MouseDownState() {}
 
 void PDFiumEngine::MouseDownState::Set(const PDFiumPage::Area& area,
                                        const PDFiumPage::LinkTarget& target) {
   area_ = area;
@@ skipping 857 matching lines @@
   FPDF_DOCUMENT doc =
       FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, nullptr);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf