Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2959773003: Share test-source between full emitter and fast startup emitter dill tests. (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Share test-source between full emitter and fast startup emitter dill tests. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4f5eb70e67f86619cca62e653e79eb452d544a04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -85 lines) Patch
M tests/compiler/dart2js/kernel/compile_from_dill_fast_startup_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-27 10:28:24 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-27 20:13:24 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-06-28 08:08:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f5eb70e67f86619cca62e653e79eb452d544a04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698