Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 295973007: Mojo: Mojom: Change order of default values and ordinals. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Mojom: Change order of default values and ordinals. Make ordinals be immediately after the member name, (possibly) followed by a default value. E.g., "int32 foo@12 = 345;" instead of "int32 foo = 345 @12". Also make the usual style "foo@12" instead of "foo @12". (Leave a few of the latter in tests, to check that whitespace is permissible.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M mojo/public/interfaces/bindings/tests/math_calculator.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 2 chunks +45 lines, -45 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 7 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-21 23:12:55 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-21 23:43:17 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-21 23:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/295973007/1
6 years, 7 months ago (2014-05-21 23:46:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 09:53:55 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 15:55:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11020)
6 years, 7 months ago (2014-05-22 15:55:51 UTC) #7
viettrungluu
6 years, 7 months ago (2014-05-22 16:38:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r272204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698